Simplify input data selector - #7
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies across the project and simplifies the PDB map configuration by removing the optional clonotype subset filter, as the PDB map is already confident-only. No review comments were provided for this pull request.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
xnacly
approved these changes
Jun 11, 2026
mzueva
force-pushed
the
mzueva/update-input-selector
branch
from
June 11, 2026 13:41
ee1bc63 to
0d47058
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on platforma-open/3d-structure-prediction#19. The upstream prediction block does not emit subset anymore and liabilities block now should use plain dataset selector instead.
Greptile Summary
This PR simplifies the input data selector for the 3D Structure-Based Liabilities block by replacing the subset-column filter with
filter: () => false, reflecting an upstream change where the prediction block no longer emits subset columns (predictionSuccessful/confident). It also bumps several@platforma-sdk/*and@milaboratories/*dependencies.predictionSuccessful|confident) withfilter: () => false. The PDB map is now pre-filtered for confidence upstream, so the dataset is selected directly; the explicitfalsefilter prevents unrelatedisSubsetcolumns from other blocks (e.g. Lead Selection) from appearing.@platforma-sdkand@milaboratoriespackages, including a major-version bump for@platforma-sdk/workflow-tengo(5.25.0 → 6.5.0).Confidence Score: 5/5
Safe to merge; the functional change is a single well-understood predicate swap consistent with the upstream PR removing subset emission.
The only functional change is replacing a two-column subset filter with
filter: () => falsein the dataset options builder. The intent is clearly stated in the inline comment, the workflow logic is untouched, and the dependency bumps align consistently across the workspace catalog and lock file.No files require special attention. The
@platforma-sdk/workflow-tengojump from 5.x to 6.x is the largest version delta, but the workflow API surface used here appears unchanged.Important Files Changed
filter: () => false; change is well-commented, intentional, and correctly prevents unrelated isSubset columns from attaching to the selector.Sequence Diagram
sequenceDiagram participant U as User participant M as Model (index.ts) participant RP as Result Pool participant WF as Workflow (main.tpl.tengo) Note over M,RP: Before this PR U->>M: Select dataset M->>RP: buildDatasetOptions (primary: pdb anchor) RP-->>M: PDB columns + subset columns (predictionSuccessful / confident) M-->>U: Show dataset + subset filter options U->>M: Pick dataset + subset Note over M,RP: After this PR U->>M: Select dataset M->>RP: buildDatasetOptions (primary: pdb anchor, filter: false) RP-->>M: PDB columns only (no subset columns surfaced) M-->>U: Show dataset selector (no subset options) U->>M: Pick dataset directly M->>WF: primaryRef (PDB column) WF->>WF: Anchor on PDB column (already confident-only upstream) WF-->>M: scoresData, pdbsMap, detectedModeReviews (1): Last reviewed commit: "Simplify input data selector" | Re-trigger Greptile