Skip to content

Simplify input data selector - #7

Merged
mzueva merged 2 commits into
mainfrom
mzueva/update-input-selector
Jun 11, 2026
Merged

mzueva merged 2 commits into
mainfrom
mzueva/update-input-selector

Conversation

@mzueva

@mzueva mzueva commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This PR depends on platforma-open/3d-structure-prediction#19. The upstream prediction block does not emit subset anymore and liabilities block now should use plain dataset selector instead.

Greptile Summary

This PR simplifies the input data selector for the 3D Structure-Based Liabilities block by replacing the subset-column filter with filter: () => false, reflecting an upstream change where the prediction block no longer emits subset columns (predictionSuccessful / confident). It also bumps several @platforma-sdk/* and @milaboratories/* dependencies.

  • model/src/index.ts: Replaces the two-column subset filter (predictionSuccessful | confident) with filter: () => false. The PDB map is now pre-filtered for confidence upstream, so the dataset is selected directly; the explicit false filter prevents unrelated isSubset columns from other blocks (e.g. Lead Selection) from appearing.
  • workflow/src/main.tpl.tengo: Comment-only update noting that the subset filter is no longer resolved; functional workflow logic is unchanged.
  • pnpm-workspace.yaml / pnpm-lock.yaml: Dependency version bumps across @platforma-sdk and @milaboratories packages, including a major-version bump for @platforma-sdk/workflow-tengo (5.25.0 → 6.5.0).

Confidence Score: 5/5

Safe to merge; the functional change is a single well-understood predicate swap consistent with the upstream PR removing subset emission.

The only functional change is replacing a two-column subset filter with filter: () => false in the dataset options builder. The intent is clearly stated in the inline comment, the workflow logic is untouched, and the dependency bumps align consistently across the workspace catalog and lock file.

No files require special attention. The @platforma-sdk/workflow-tengo jump from 5.x to 6.x is the largest version delta, but the workflow API surface used here appears unchanged.

Important Files Changed

Filename Overview
model/src/index.ts Replaces old subset-column filter with filter: () => false; change is well-commented, intentional, and correctly prevents unrelated isSubset columns from attaching to the selector.
workflow/src/main.tpl.tengo Comment-only change noting the removal of the subset filter; all functional workflow logic is unchanged.
pnpm-workspace.yaml Catalog version bumps for platforma-sdk and milaboratories packages; consistent with the lock file.
pnpm-lock.yaml Lock file regenerated to reflect catalog bumps; versions align with workspace catalog entries.

Sequence Diagram

sequenceDiagram
    participant U as User
    participant M as Model (index.ts)
    participant RP as Result Pool
    participant WF as Workflow (main.tpl.tengo)

    Note over M,RP: Before this PR
    U->>M: Select dataset
    M->>RP: buildDatasetOptions (primary: pdb anchor)
    RP-->>M: PDB columns + subset columns (predictionSuccessful / confident)
    M-->>U: Show dataset + subset filter options
    U->>M: Pick dataset + subset

    Note over M,RP: After this PR
    U->>M: Select dataset
    M->>RP: buildDatasetOptions (primary: pdb anchor, filter: false)
    RP-->>M: PDB columns only (no subset columns surfaced)
    M-->>U: Show dataset selector (no subset options)
    U->>M: Pick dataset directly

    M->>WF: primaryRef (PDB column)
    WF->>WF: Anchor on PDB column (already confident-only upstream)
    WF-->>M: scoresData, pdbsMap, detectedMode
Loading

Reviews (1): Last reviewed commit: "Simplify input data selector" | Re-trigger Greptile

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies across the project and simplifies the PDB map configuration by removing the optional clonotype subset filter, as the PDB map is already confident-only. No review comments were provided for this pull request.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@mzueva
mzueva requested a review from xnacly June 11, 2026 09:57
@mzueva
mzueva force-pushed the mzueva/update-input-selector branch from ee1bc63 to 0d47058 Compare June 11, 2026 13:41
@mzueva
mzueva merged commit 032ad61 into main Jun 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants