Support DMS VDJ datasets - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR adds designed-library and DMS profiler support by classifying datasets from axis-domain metadata, offering profiler sequence columns, applying long-sequence matching behavior, and publishing variant-specific labels.
Important touched terms:
Modality — the biological category that controls defaults and workflow behavior; expanded from
antibody_tcr | peptideto includeamplicon.Amplicon — a designed-library or DMS variant dataset whose sequences are treated as long sequences; introduced as a distinct modality with antibody/TCR-style matching defaults and variant-facing output labels.
SequenceFamily — the namespace and shape of available sequence columns; introduced with
peptide,universal, andvdjvalues so biological modality is independent of column namespace.InputClass — the combined dataset classification containing
modalityandsequences; introduced to let VDJ profiler datasets retain antibody/TCR semantics while using universal sequence columns.classifyDataset — the model-side classifier derived from the entity-axis name and domain; introduced to drive model modality output and target-column choices.
datasetModality — the workflow-side modality classifier; expanded from a peptide Boolean check to three-way classification using declarations and producer run IDs.
lastAppliedModality — persisted context identifying which modality supplied the current defaults; its runtime contract now accepts
amplicon.Target options — sequence columns offered for matching; profiler inputs now expose feature-tagged
pl7.app/sequencecolumns, including whole-variant and regional sequences.Recognizes declared
vdjandampliconprofiler datasets.Falls back to producer-specific run-ID keys for undeclared datasets.
Keeps short-peptide search adaptation limited to peptide inputs.
Labels amplicon results as matched variants and variant-to-assay links.
Adds Tengo modality tests and kind validation coverage.
Confidence Score: 4/5
The PR appears safe to merge, with a non-blocking recommendation to test the model-side copy of the modality-routing contract.
The current TypeScript and Tengo classifiers agree across the supported dataset shapes, and downstream matching behavior, sequence selection, validation, and labels consistently handle amplicon. The remaining concern is regression risk from maintaining two classifier implementations while directly testing only one.
Files Needing Attention: model/src/modality.ts
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Dataset entity axis] --> B{Model classifyDataset} A --> C{Workflow datasetModality} B --> D[Biological modality] B --> E[Sequence family] D --> F[UI threshold defaults] E --> G[Target sequence options] C --> H[Peptide search adaptation] C --> I[Clone, peptide, or variant labels]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Support DMS VDJ datasets" | Re-trigger Greptile
Context used (5)