Update sdk - #10
Update sdk#10
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies across the workspace, including @milaboratories/graph-maker and various @platforma-sdk packages, and adds vue to the workspace catalog. Feedback points out a version inconsistency for vue between the catalog and the lock file, recommending an update to version 3.5.25 to avoid potential runtime issues from duplicate instances.
|
|
||
| "@platforma-open/milaboratories.runenv-python-3": 1.8.2 | ||
|
|
||
| "vue": 3.5.24 |
There was a problem hiding this comment.
The catalog specifies vue: 3.5.24, but several other dependencies in the project (such as @milaboratories/graph-maker and @vueuse/core) are pulling in vue@3.5.25 as seen in the lock file. This inconsistency leads to duplicate Vue instances being bundled, which can cause runtime issues (e.g., with Provide/Inject or global configurations) and increases the bundle size. Aligning the catalog version with 3.5.25 is recommended to ensure a single version is used across the workspace.
"vue": 3.5.25| specifier: 'catalog:' | ||
| version: 2.5.26 | ||
| version: 2.5.29 | ||
| '@platforma-sdk/test': |
There was a problem hiding this comment.
@milaboratories/graph-maker@1.4.2 (and @milaboratories/pf-plots@1.4.1) still declare exact peer dependencies on @platforma-sdk/model: 1.73.3 and @platforma-sdk/ui-vue: 1.73.3, while the workspace catalog now supplies 1.77.0. pnpm resolves this by satisfying the peer with whatever is available in context, meaning the model importer ends up with graph-maker bound to @platforma-sdk/ui-vue@1.73.3 while the ui importer gets 1.77.0 — two different resolutions for the same package. This is not a hard blocker if the APIs are backward-compatible, but it may produce pnpm peer-dependency warnings in CI and could cause subtle mismatches if either package relies on internals that changed between 1.73.3 and 1.77.0.
Prompt To Fix With AI
This is a comment left during a code review.
Path: pnpm-lock.yaml
Line: 249-251
Comment:
`@milaboratories/graph-maker@1.4.2` (and `@milaboratories/pf-plots@1.4.1`) still declare exact peer dependencies on `@platforma-sdk/model: 1.73.3` and `@platforma-sdk/ui-vue: 1.73.3`, while the workspace catalog now supplies `1.77.0`. pnpm resolves this by satisfying the peer with whatever is available in context, meaning the `model` importer ends up with `graph-maker` bound to `@platforma-sdk/ui-vue@1.73.3` while the `ui` importer gets `1.77.0` — two different resolutions for the same package. This is not a hard blocker if the APIs are backward-compatible, but it may produce pnpm peer-dependency warnings in CI and could cause subtle mismatches if either package relies on internals that changed between `1.73.3` and `1.77.0`.
How can I resolve this? If you propose a fix, please make it concise.| "@platforma-sdk/model": "catalog:", | ||
| "@platforma-sdk/ui-vue": "catalog:" | ||
| "@platforma-sdk/ui-vue": "catalog:", | ||
| "vue": "catalog:" |
There was a problem hiding this comment.
The catalog pins
vue to 3.5.24, but the previous wildcard "*" was already resolving to 3.5.25 (visible in pnpm-lock.yaml before this PR). Switching to "catalog:" therefore downgrades Vue by one patch release. If 3.5.24 is the intended version that's fine, but it's worth double-checking that the catalog entry wasn't set one release behind by accident.
Prompt To Fix With AI
This is a comment left during a code review.
Path: ui/package.json
Line: 17
Comment:
The catalog pins `vue` to `3.5.24`, but the previous wildcard `"*"` was already resolving to `3.5.25` (visible in `pnpm-lock.yaml` before this PR). Switching to `"catalog:"` therefore downgrades Vue by one patch release. If `3.5.24` is the intended version that's fine, but it's worth double-checking that the catalog entry wasn't set one release behind by accident.
How can I resolve this? If you propose a fix, please make it concise.
Greptile Summary
This PR bumps several
@platforma-sdk/*and@milaboratories/*SDK packages to their latest versions, addsvueto the workspace catalog, and pins theuipackage'svuedependency to the catalog entry.@platforma-sdk/model,@platforma-sdk/ui-vue,@platforma-sdk/test,@platforma-sdk/workflow-tengo, and@milaboratories/graph-makerare all bumped to newer minor/patch releases;pnpm-lock.yamlis regenerated accordingly.ui/package.jsonchangesvuefrom"*"to"catalog:", pinning it to3.5.24— one patch behind the3.5.25that"*"previously resolved to.@milaboratories/graph-maker@1.4.2retains peer dependency declarations pointing to@platforma-sdk/model@1.73.3and@platforma-sdk/ui-vue@1.73.3, causing pnpm to resolve thegraph-makerpeer differently across themodelvsuiimporters.Confidence Score: 4/5
Safe to merge; changes are confined to dependency manifests and the lock file with no logic modifications.
The only noteworthy items are a one-patch Vue downgrade (3.5.25 → 3.5.24) introduced by pinning via the catalog, and the graph-maker package carrying stale exact peer declarations that cause pnpm to resolve it against different ui-vue versions in the model vs ui importers. Neither is likely to produce a runtime regression, but both are worth a quick confirmation before merging.
ui/package.json (vue version pin) and pnpm-lock.yaml (graph-maker dual-resolution of @platforma-sdk/ui-vue)
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD catalog["pnpm-workspace.yaml catalog\n@platforma-sdk/model: 1.77.0\n@platforma-sdk/ui-vue: 1.77.0\nvue: 3.5.24"] catalog --> ui["ui package\nvue: catalog → 3.5.24\n@platforma-sdk/ui-vue: 1.77.0\n@platforma-sdk/model: 1.77.0"] catalog --> model["model package\n@platforma-sdk/model: 1.77.0"] catalog --> test["test package\n@platforma-sdk/test: 1.77.1"] ui --> gmUI["graph-maker@1.4.2\nresolved with ui-vue@1.77.0"] model --> gmModel["graph-maker@1.4.2\nresolved with ui-vue@1.73.3\n⚠ peer mismatch"] gmUI -. peer declared .-> peerDecl["peer dep declared:\n@platforma-sdk/model@1.73.3\n@platforma-sdk/ui-vue@1.73.3"] gmModel -. peer declared .-> peerDeclPrompt To Fix All With AI
Reviews (1): Last reviewed commit: "update dependencies" | Re-trigger Greptile