fix: re-resolve graph data-mapping on dataset switch - #37
Merged
Conversation
Bump @milaboratories/graph-maker 1.1.222 -> 1.4.6. The old version gated default re-resolution behind a data-state-key change and never overwrote a non-readonly axis that already held a selection, so switching datasets left the previous dataset's columns in the chart as "Inconsistent value" with no graph. 1.4.x re-resolves defaults automatically when the pframe changes (the version other blocks on this SDK line already use).
There was a problem hiding this comment.
Code Review
This pull request bumps the @milaboratories/graph-maker dependency from version 1.1.222 to 1.4.6 to resolve an issue with stale graph data-mapping when switching datasets. The reviewer suggests including the @platforma-open/milaboratories.vj-usage.model package in the changeset file as well, since it also depends on @milaboratories/graph-maker and needs its version bumped.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Selecting a dataset, running, then switching to a different dataset and running again left the chart's data-mapping pointing at the previous dataset's columns — shown as "Inconsistent value" with no graph. Fresh pages (never opened under the first dataset) rendered correctly, and the weighted/unweighted toggle kept working, which narrowed it down to stale persisted axis selections.
Root cause
The block was pinned to
@milaboratories/graph-maker1.1.222, which gates its default re-resolution behind adata-state-keychange and, in that pass, never overwrites a non-readonly axis that already holds a selection. So a dataset switch never cleared the previous dataset's columns. graph-maker 1.4.x removed that gating and re-resolves defaults automatically when the pframe changes — which is why other blocks on this SDK line (e.g. embedding-clustering: SDK 1.79.17 + graph-maker 1.4.6) don't hit this.Change
Bump the graph-maker catalog pin
1.1.222 → 1.4.6. No block source changes. Builds clean; 1.4.6 is already proven compatible with this SDK line by sibling blocks.Greptile Summary
Bumps
@milaboratories/graph-makerfrom1.1.222to1.4.6in the pnpm workspace catalog to fix stale chart axis mappings after a dataset switch. No block source code changes are required — the fix is entirely within the new library version.data-state-keychange; switching datasets never triggered that key, leaving previous columns in the chart as "Inconsistent value". Version 1.4.6 re-resolves defaults unconditionally when thepframechanges.miplots4 1.0.172 → 1.2.2,pf-plots 1.1.61 → 1.4.4,helpers 1.13.0 → 1.14.2(graph-maker internal),zod 3.24.2removed.rolldown-plugin-dtspeer key normalized totypescript@5.9.3across all snapshots;@vitest/coverage-istanbul@4.1.9now resolves againstvitest@4.0.16inside thevitest@4.1.9snapshot (cross-version peer mismatch worth verifying in CI).Touched Terms
catalog:@milaboratories/graph-makerpin changed1.1.222 → 1.4.6@milaboratories/graph-makerpframechangesdata-state-keypframechangepframe(PlatformaFrame)@milaboratories/miplots41.0.172 → 1.2.2as part of the graph-maker upgrade@milaboratories/pf-plots1.1.61 → 1.4.4; peer dep constraints tightened to exact1.73.3for@platforma-sdk/modelConfidence Score: 4/5
Safe to merge — the change is a well-scoped catalog pin with no source-code edits, and the target version is already proven in sibling blocks.
The graph-maker bump itself is straightforward and the changeset is accurately documented. The only thing worth a second look is the @vitest/coverage-istanbul peer wiring in the regenerated lockfile, where vitest@4.1.9's optional coverage dep now resolves against a vitest@4.0.16 snapshot — a cross-version pairing generated by pnpm. If coverage is exercised in CI with vitest@4.1.9, it would be worth confirming that coverage output is unaffected.
pnpm-lock.yaml — the vitest/coverage-istanbul snapshot wiring is worth a quick CI coverage check.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[User selects Dataset A & runs block] --> B[graph-maker initializes axis mappings\nto Dataset A columns] B --> C[User switches to Dataset B & runs again] C --> D{graph-maker version?} D -->|1.1.222 - old| E{Did data-state-key change?} E -->|No - dataset switch\ndoes not change key| F[Axis mappings kept from Dataset A] F --> G["Chart shows 'Inconsistent value'\nNo graph rendered"] D -->|1.4.6 - new| H[pframe changed detected\nunconditional re-resolution] H --> I[Axis defaults resolved\nto Dataset B columns] I --> J[Graph renders correctly]%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% flowchart TD A[User selects Dataset A & runs block] --> B[graph-maker initializes axis mappings\nto Dataset A columns] B --> C[User switches to Dataset B & runs again] C --> D{graph-maker version?} D -->|1.1.222 - old| E{Did data-state-key change?} E -->|No - dataset switch\ndoes not change key| F[Axis mappings kept from Dataset A] F --> G["Chart shows 'Inconsistent value'\nNo graph rendered"] D -->|1.4.6 - new| H[pframe changed detected\nunconditional re-resolution] H --> I[Axis defaults resolved\nto Dataset B columns] I --> J[Graph renders correctly]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "fix: re-resolve graph data-mapping on da..." | Re-trigger Greptile
Context used: