Skip to content

fix: re-resolve graph data-mapping on dataset switch #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vadimpiven merged 1 commit into from
Jun 29, 2026
Merged

fix: re-resolve graph data-mapping on dataset switch #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/bump-graph-maker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@platforma-open/milaboratories.vj-usage.ui": patch
"@platforma-open/milaboratories.vj-usage": patch
Comment thread
vadimpiven marked this conversation as resolved.
---

Fix stale graph data-mapping when switching datasets. graph-maker 1.1.222 gated
its default re-resolution behind a `data-state-key` change, so switching the
dataset left the previous dataset's columns in the chart as "Inconsistent value"
with no graph. Bump graph-maker to 1.4.6 (same version other blocks on this SDK
line use), which re-resolves defaults automatically when the pframe changes.
80 changes: 46 additions & 34 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ catalog:
'@platforma-sdk/block-tools': 2.11.1
'@platforma-sdk/test': 1.79.15
'@milaboratories/helpers': 1.13.0
'@milaboratories/graph-maker': 1.1.222
'@milaboratories/graph-maker': 1.4.6
'@milaboratories/strings': 0.1.0

# Common dependencies - can use ^ or ~
Expand Down
Loading