Add missing flag in prepublishOnly - #39
Merged
julenmendieta merged 1 commit intoJul 17, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the missing --registry-serve-url flag to the prepublishOnly script in block/package.json and includes a corresponding changeset file for a patch release of @platforma-open/milaboratories.vj-usage. No review comments were provided, and the changes look correct.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR adds the missing
--registry-serve-urlflag to theprepublishOnlyscript inblock/package.json, ensuring thatblock-tools publishreceives the public serve URL alongside the S3 storage registry path. A corresponding patch changeset entry is included.block/package.jsonprepublishOnly: Appends--registry-serve-urlpointing to the public blocks serve domain so the published block is correctly associated with its serve endpoint..changeset/fast-clubs-watch.md: Registers apatchbump for@platforma-open/milaboratories.vj-usageto record the fix in the changelog.Confidence Score: 5/5
Safe to merge — the change is a single-flag addition to a publish script with no runtime or logic impact.
The only change is appending --registry-serve-url to block-tools publish in the prepublishOnly script. Without this flag the published block would lack its public serve URL, so the fix is correct and intentional. No application logic, dependencies, or data paths are touched.
No files require special attention.
Important Files Changed
Sequence Diagram
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant Dev as Developer participant pnpm as pnpm publish participant bt as block-tools publish participant s3 as S3 Block Registry participant serve as blocks.pl-open.science Dev->>pnpm: npm publish / pnpm publish pnpm->>bt: prepublishOnly script bt->>s3: "Upload packed block (-r s3://...?region=eu-central-1)" Note over bt,serve: NEW: --registry-serve-url flag bt->>serve: Register serve URL (blocks.pl-open.science)%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant Dev as Developer participant pnpm as pnpm publish participant bt as block-tools publish participant s3 as S3 Block Registry participant serve as blocks.pl-open.science Dev->>pnpm: npm publish / pnpm publish pnpm->>bt: prepublishOnly script bt->>s3: "Upload packed block (-r s3://...?region=eu-central-1)" Note over bt,serve: NEW: --registry-serve-url flag bt->>serve: Register serve URL (blocks.pl-open.science)Reviews (1): Last reviewed commit: "Add missing flag in prepublishOnly" | Re-trigger Greptile