Skip to content

Add missing flag in prepublishOnly - #39

Merged
julenmendieta merged 1 commit into
mainfrom
julenmendieta/MILAB-6617_adaptToSingleCellVhh
Jul 17, 2026
Merged

Add missing flag in prepublishOnly#39
julenmendieta merged 1 commit into
mainfrom
julenmendieta/MILAB-6617_adaptToSingleCellVhh

Conversation

@julenmendieta

@julenmendieta julenmendieta commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds the missing --registry-serve-url flag to the prepublishOnly script in block/package.json, ensuring that block-tools publish receives the public serve URL alongside the S3 storage registry path. A corresponding patch changeset entry is included.

  • block/package.json prepublishOnly: Appends --registry-serve-url pointing to the public blocks serve domain so the published block is correctly associated with its serve endpoint.
  • .changeset/fast-clubs-watch.md: Registers a patch bump for @platforma-open/milaboratories.vj-usage to record the fix in the changelog.

Confidence Score: 5/5

Safe to merge — the change is a single-flag addition to a publish script with no runtime or logic impact.

The only change is appending --registry-serve-url to block-tools publish in the prepublishOnly script. Without this flag the published block would lack its public serve URL, so the fix is correct and intentional. No application logic, dependencies, or data paths are touched.

No files require special attention.

Important Files Changed

Filename Overview
block/package.json Adds --registry-serve-url to the prepublishOnly script; no other changes. Change is consistent with how the flag would need to be supplied to block-tools publish.
.changeset/fast-clubs-watch.md New changeset file declaring a patch version bump for the @platforma-open/milaboratories.vj-usage package.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant Dev as Developer
    participant pnpm as pnpm publish
    participant bt as block-tools publish
    participant s3 as S3 Block Registry
    participant serve as blocks.pl-open.science

    Dev->>pnpm: npm publish / pnpm publish
    pnpm->>bt: prepublishOnly script
    bt->>s3: "Upload packed block (-r s3://...?region=eu-central-1)"
    Note over bt,serve: NEW: --registry-serve-url flag
    bt->>serve: Register serve URL (blocks.pl-open.science)
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant Dev as Developer
    participant pnpm as pnpm publish
    participant bt as block-tools publish
    participant s3 as S3 Block Registry
    participant serve as blocks.pl-open.science

    Dev->>pnpm: npm publish / pnpm publish
    pnpm->>bt: prepublishOnly script
    bt->>s3: "Upload packed block (-r s3://...?region=eu-central-1)"
    Note over bt,serve: NEW: --registry-serve-url flag
    bt->>serve: Register serve URL (blocks.pl-open.science)
Loading

Reviews (1): Last reviewed commit: "Add missing flag in prepublishOnly" | Re-trigger Greptile

@julenmendieta
julenmendieta merged commit a0ac00c into main Jul 17, 2026
2 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the missing --registry-serve-url flag to the prepublishOnly script in block/package.json and includes a corresponding changeset file for a patch release of @platforma-open/milaboratories.vj-usage. No review comments were provided, and the changes look correct.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@julenmendieta
julenmendieta deleted the julenmendieta/MILAB-6617_adaptToSingleCellVhh branch July 17, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant