MILAB-6848: fix sc TCR domain mapping - #42
Open
mchernys wants to merge 2 commits into
Open
Conversation
The chain mapping fix reordered the selector to Beta/Alpha and Delta/Gamma, since array order is display order. Keep the producers' values and order the labels Alpha/Beta and Gamma/Delta instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR corrects the display mapping between single-cell TCR chain letters and biological chain names while preserving stored chain values, so existing analyses are relabelled without rerunning.
scChain) — persisted producer-position code used to select workflow columns; itsAandBvalues remain unchanged.A = Alpha, B = BetatoA = Beta, B = Alpha.A = Gamma, B = DeltatoA = Delta, B = Gamma.Confidence Score: 5/5
The PR appears safe to merge because it changes only the user-facing TCR chain labels while retaining the persisted values used by the workflow.
The selector still sends the same A/B chain codes through the model to workflow filtering, while the displayed TCRAB and TCRGD names are corrected to match the documented producer convention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR D[Dataset receptor domain] --> R{Receptor} R -->|TCRAB| AB[A = Beta<br/>B = Alpha] R -->|TCRGD| GD[A = Delta<br/>B = Gamma] AB --> S[Persisted scChain value A or B] GD --> S S --> W[Workflow chain-column filter] S --> L[Corrected user-facing label]Reviews (1): Last reviewed commit: "MILAB-6848: fix sc TCR domain mapping" | Re-trigger Greptile
Context used: