Skip to content

MILAB-6848: fix sc TCR domain mapping - #42

Open
mchernys wants to merge 2 commits into
mainfrom
MILAB-6848_fix-sc-TCR-domain-mapping
Open

MILAB-6848: fix sc TCR domain mapping#42
mchernys wants to merge 2 commits into
mainfrom
MILAB-6848_fix-sc-TCR-domain-mapping

Conversation

@mchernys

@mchernys mchernys commented Aug 31, 2026

Copy link
Copy Markdown

Greptile Summary

The PR corrects the display mapping between single-cell TCR chain letters and biological chain names while preserving stored chain values, so existing analyses are relabelled without rerunning.

  • Single-cell chain (scChain) — persisted producer-position code used to select workflow columns; its A and B values remain unchanged.
  • TCRAB — alpha/beta T-cell receptor type; its options change from A = Alpha, B = Beta to A = Beta, B = Alpha.
  • TCRGD — gamma/delta T-cell receptor type; its options change from A = Gamma, B = Delta to A = Delta, B = Gamma.
  • Receptor domain — dataset metadata identifying receptor type; it continues to determine which chain options the selector displays.
  • Chain label — user-facing biological chain name associated with a stored letter; only this presentation mapping changes.

Confidence Score: 5/5

The PR appears safe to merge because it changes only the user-facing TCR chain labels while retaining the persisted values used by the workflow.

The selector still sends the same A/B chain codes through the model to workflow filtering, while the displayed TCRAB and TCRGD names are corrected to match the documented producer convention.

Important Files Changed

Filename Overview
ui/src/utils.ts Corrects the TCRAB and TCRGD labels associated with unchanged A/B producer-position values; no concrete defect was established.
.changeset/fix-sc-tcr-chain-letters.md Documents the corrected producer mapping, compatibility behavior for existing blocks, and minor package releases.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  D[Dataset receptor domain] --> R{Receptor}
  R -->|TCRAB| AB[A = Beta<br/>B = Alpha]
  R -->|TCRGD| GD[A = Delta<br/>B = Gamma]
  AB --> S[Persisted scChain value A or B]
  GD --> S
  S --> W[Workflow chain-column filter]
  S --> L[Corrected user-facing label]
Loading

Reviews (1): Last reviewed commit: "MILAB-6848: fix sc TCR domain mapping" | Re-trigger Greptile

Context used:

The chain mapping fix reordered the selector to Beta/Alpha and Delta/Gamma,
since array order is display order. Keep the producers' values and order the
labels Alpha/Beta and Gamma/Delta instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant