Repository navigation
Refactor test runner - #49
Merged
Merged
Conversation
Reduce the size of the main procedure in the runner.
Reduce the size of the main procedure in the runner.
Reduce the size of the main procedure in the runner.
Reduce the size of the main procedure in the runner.
No need to clutter up the let form where they are just used in one place each.
And instead exit as soon as something fails. It will now only return the value of EXIT_SUCCESS or EXIT_FAILURE depending if it succeeded or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main procedure got a bit long and used some imperative notions for setting the exit-code. Refactor it by breaking out the setup, run command, check and clean up code into separate procedures. This allowed to remove the mutation of the
exit-statusand instead combine the stages usingand. Which also allows it to stop as soon as one of the stages fails. Which should generate easier to read error reports.