From ec714845fa7c8549605f57ae6e35df6bcd6afecd Mon Sep 17 00:00:00 2001 From: Fredrik Salomonsson Date: Wed, 26 Nov 2025 20:53:56 -0800 Subject: [PATCH 1/5] Update build-aux/version to operate on the full version Works better with my devtools to automatically commit version changes. --- build-aux/version | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/build-aux/version b/build-aux/version index 556e728..26133f6 100755 --- a/build-aux/version +++ b/build-aux/version @@ -4,11 +4,7 @@ # # SPDX-License-Identifier: GPL-3.0-or-later -major=2 -minor=5 -patch=0 - -version=$major.$minor.$patch +version=2.5.0 read -rd '' help < Date: Wed, 26 Nov 2025 21:17:58 -0800 Subject: [PATCH 2/5] Set version in scrips using meson's configure_file [#52] To avoid the issue of forgetting to bump them when releasing a new version. Which I've been doing for the last few versions. --- baksnapper.sh | 2 +- baksnapperd-denotebak.sh | 2 +- baksnapperd.sh | 2 +- meson.build | 130 +++++++++++++++++---------------------- 4 files changed, 58 insertions(+), 78 deletions(-) mode change 100644 => 100755 baksnapperd-denotebak.sh diff --git a/baksnapper.sh b/baksnapper.sh index 0ba3b47..fbafcab 100755 --- a/baksnapper.sh +++ b/baksnapper.sh @@ -127,7 +127,7 @@ Fredrik "PlaTFooT" Salomonsson EOF read -rd '' version <. diff --git a/baksnapperd-denotebak.sh b/baksnapperd-denotebak.sh old mode 100644 new mode 100755 index 65244a3..aee729f --- a/baksnapperd-denotebak.sh +++ b/baksnapperd-denotebak.sh @@ -7,7 +7,7 @@ # SPDX-License-Identifier: GPL-3.0-or-later read -rd '' version <. This is free software: you are free to change and redistribute it. diff --git a/baksnapperd.sh b/baksnapperd.sh index 9cdbb9c..280989a 100755 --- a/baksnapperd.sh +++ b/baksnapperd.sh @@ -9,7 +9,7 @@ # SPDX-License-Identifier: GPL-3.0-or-later read -rd '' version < Date: Wed, 26 Nov 2025 21:32:05 -0800 Subject: [PATCH 3/5] Update Makefile to replace @VERSION@ with the current version [#52] --- Makefile | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 4897454..00306e6 100644 --- a/Makefile +++ b/Makefile @@ -30,9 +30,13 @@ $(PREFIX_BIN) $(PREFIX_LIB)/systemd/system $(PREFIX_ETC)/baksnapper/example: .PHONY: install bin systemd etc install: bin systemd +__root_dir=$(dir $(abspath $(lastword $(MAKEFILE_LIST)))) +__version=$(shell $(__root_dir)build-aux/version) bin: | $(PREFIX_BIN) - @install baksnapper.sh $|/baksnapper - @install baksnapperd.sh $|/baksnapperd + @sed 's/@VERSION@/${__version}/' baksnapper.sh > $|/baksnapper + @chmod 744 $|/baksnapper + @sed 's/@VERSION@/${__version}/' baksnapperd.sh > $|/baksnapperd + @chmod 744 $|/baksnapperd systemd: etc | $(PREFIX_LIB)/systemd/system @install --mode=644 systemd/baksnapper@.timer $|/ From 7731a477fd43f6db689c91bb24c2fbd5018d5662 Mon Sep 17 00:00:00 2001 From: Fredrik Salomonsson Date: Wed, 26 Nov 2025 21:33:56 -0800 Subject: [PATCH 4/5] changelog: set version in scripts using meson/make --- .../20251126T213311--set-version-from-mesonmake__changed.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 CHANGELOG.d/20251126T213311--set-version-from-mesonmake__changed.md diff --git a/CHANGELOG.d/20251126T213311--set-version-from-mesonmake__changed.md b/CHANGELOG.d/20251126T213311--set-version-from-mesonmake__changed.md new file mode 100644 index 0000000..8f054fc --- /dev/null +++ b/CHANGELOG.d/20251126T213311--set-version-from-mesonmake__changed.md @@ -0,0 +1,4 @@ + + +### Changed +- Set version in scripts using meson/make. [#52](https://github.com/plattfot/baksnapper/issues/52) From 230ec84cf85a9e40b2488e28cfab2fcbf508ec0a Mon Sep 17 00:00:00 2001 From: Fredrik Salomonsson Date: Wed, 26 Nov 2025 21:38:25 -0800 Subject: [PATCH 5/5] Add simple smoke tests for the scripts in the Makefile CI --- .github/workflows/makefile.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/makefile.yml b/.github/workflows/makefile.yml index 02f338e..086ec6a 100644 --- a/.github/workflows/makefile.yml +++ b/.github/workflows/makefile.yml @@ -21,3 +21,7 @@ jobs: run: mkdir -p build/{usr/bin,usr/lib,etc} - name: Build and install run: make install PREFIX=build + - name: Smoke test baksnapper + run: ./build/usr/bin/baksnapper --version + - name: Smoke test baksnapperd + run: ./build/usr/bin/baksnapperd --version