fix(container): use scoped binding for parser - #12
Merged
Merged
Conversation
KmlParser holds the loaded SimpleXMLElement as instance state, so the singleton binding kept a parsed document alive across Octane requests and across jobs in a long running queue worker. Any consumer resolving the parser without loading first could read another request's document. A scoped binding keeps the instance stable for the whole request or job (so the documented facade chaining still works) while the container flushes it between lifecycles.
danielebarbaro
force-pushed
the
fix/octane-safe-container-binding
branch
from
September 8, 2026 12:33
dacfcff to
c92785b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
KmlParserServiceProviderregistersKmlParseras a singleton, but the parser holds the loaded document as mutable instance state (protected ?SimpleXMLElement $xml).Under Octane, or inside a long running queue worker, the container is reused across requests/jobs. That means:
KmlParser::loadFromFile('customer-a.kml').getPlacemarks()without loading anything.No KML data loadedexception.Cross-request data leakage, and it fails open (returns wrong data) rather than erroring. Note that
phpstan.neon.distalready setscheckOctaneCompatibility: true; static analysis does not catch this class of stateful-singleton issue.Fix
Swap
singleton()forscoped(). A scoped binding behaves exactly like a singleton for the duration of a request or job, so the chained facade usage documented in the README keeps working:but the container flushes it between lifecycles, so nothing carries over.
Tests
Three tests in
tests/ServiceProviderTest.php, the third one being the actual regression test (it fails onmain):forgetScopedInstances()Notes
vendor/bin/pint --testcurrently reportssrc/KmlParser.phpas unformatted onmainalready. Untouched here to keep the diff focused.