Skip to content

Commit c5c17a3

Browse files
build(rector): require the versions the config depends on
rector.php skips three rules by class name, and Rector fails hard when a skipped rule does not exist. On a prefer-lowest build the previous constraints resolved rector 2.0.0 and rector-laravel 2.0.0, where none of the three had been written yet: [ERROR] These rules from "$rectorConfig->skip()" does not exist * RectorLaravel\Rector\FuncCall\AppToResolveRector * RectorLaravel\Rector\ClassMethod\MakeModelAttributesAndScopesProtectedRector * Rector\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector Both constraints move to ^2.6, the range that carries them. Verified on the two ends of the matrix: Laravel 12 with prefer-lowest, which resolves rector 2.6.4 and rector-laravel 2.6.1, and Laravel 13 with prefer-stable. Both dependencies are dev only, so nothing changes for an application installing the package.
1 parent 8173b69 commit c5c17a3

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"spatie/laravel-query-builder": "^7.3.1"
3030
},
3131
"require-dev": {
32-
"driftingly/rector-laravel": "^2.0",
32+
"driftingly/rector-laravel": "^2.6",
3333
"larastan/larastan": "^3.9",
3434
"laravel/pao": "^1.0",
3535
"laravel/pint": "^1.29",
@@ -42,7 +42,7 @@
4242
"phpstan/extension-installer": "^1.4",
4343
"phpstan/phpstan-deprecation-rules": "^2.0",
4444
"phpstan/phpstan-phpunit": "^2.0",
45-
"rector/rector": "^2.0"
45+
"rector/rector": "^2.6"
4646
},
4747
"autoload": {
4848
"psr-4": {

0 commit comments

Comments
 (0)