Run PHPStan over the tests too, and fix what it found

Adds tests/ to the PHPStan paths so the test suite is held to the same
level 5 as src. The nine errors that surfaced:

Resource::setId() and setIdOrFail() were declared ": self", which resolves
to Resource rather than the called class, so chaining off them lost the
concrete type. A "@return static" docblock fixes it at the source, which
also helps anyone running static analysis against the SDK.

Two of the findings were real bugs in the live tests:

  SiteTest::testCreateExampleDotCom() dropped the result of its own
  recursive call and then fell off the end of a method declared to return
  stdClass, so the @Depends chain got null after cleaning up a leftover
  site. Its $foundSite flag was also dead - never set true, so the break
  was unreachable.

  SshKeyTest::testDeleteSshKey() wrapped its only assertion in
  "if (!empty($sshKey))" on a parameter typed stdClass, which can never be
  empty. Harmless, but it hid that the guard did nothing.

The rest were assertions that could not fail: assertIsArray() on
Response::toArray() and on getHistory(), both of which are declared to
return arrays. Replaced with assertions that check something.

Author: Cannonb4ll

phpstan.neon

@@ -2,3 +2,4 @@ parameters:
 	level: 5
 	paths:
 		- src
+		- tests

src/Ploi/Resources/Resource.php

@@ -31,6 +31,9 @@ public function __construct(?Ploi $ploi = null, ?int $id = null)
         }
     }
 
+    /**
+     * @return static
+     */
     public function setId(?int $id = null): self
     {
         $this->id = $id;
@@ -40,6 +43,9 @@ public function setId(?int $id = null): self
         return $this;
     }
 
+    /**
+     * @return static
+     */
     public function setIdOrFail(?int $id = null): self
     {
         if ($id) {

tests/Integration/Resources/ServerTest.php

@@ -59,7 +59,7 @@ public function testGetAllServers()
         $this->assertInstanceOf(\stdClass::class, $servers->getJson());
 
         // Test the array response
-        $this->assertIsArray($servers->toArray());
+        $this->assertSame(['json', 'response'], array_keys($servers->toArray()));
 
         // Test to make sure that the data is an array
         $this->assertIsArray($servers->getJson()->data);
@@ -84,8 +84,8 @@ public function testGetPaginatedServers()
         $this->assertInstanceOf(\stdClass::class, $serversPage2->getJson());
 
         // Test the array response
-        $this->assertIsArray($serversPage1->toArray());
-        $this->assertIsArray($serversPage2->toArray());
+        $this->assertSame(['json', 'response'], array_keys($serversPage1->toArray()));
+        $this->assertSame(['json', 'response'], array_keys($serversPage2->toArray()));
 
         // Test responses contain paginated result
         $this->assertEquals(1, $serversPage1->getJson()->meta->current_page);

tests/Integration/Resources/SiteTest.php

@@ -102,18 +102,16 @@ public function testCreateExampleDotCom(): stdClass
             $this->assertInstanceOf(NotValid::class, $e);
 
             $allSites = $this->server->sites()->get();
-            $foundSite = false;
-            foreach ($allSites->getJson()->data as $site) {
-                if ($foundSite) {
-                    break;
-                }
 
+            foreach ($allSites->getJson()->data as $site) {
                 if ($site->domain === 'example.com') {
                     $this->server->sites($site->id)->delete();
 
-                    $this->testCreateExampleDotCom();
+                    return $this->testCreateExampleDotCom();
                 }
             }
+
+            $this->fail('Could not create example.com and found no existing site to remove');
         }
     }
 

tests/Integration/Resources/SshKeyTest.php

@@ -98,10 +98,9 @@ public function testCreateSshKey(): stdClass
      */
     public function testDeleteSshKey(stdClass $sshKey)
     {
-        if (!empty($sshKey)) {
-            $deleted = $this->server->sshKeys($sshKey->id)->delete();
-            $this->assertTrue($deleted->getResponse()->getStatusCode() === 200);
-        }
+        $deleted = $this->server->sshKeys($sshKey->id)->delete();
+
+        $this->assertTrue($deleted->getResponse()->getStatusCode() === 200);
     }
 
     public function testDeleteInvalidSshKey()

tests/Unit/Traits/HistoryTest.php

@@ -23,7 +23,8 @@ protected function setUp(): void
 
     public function testGetHistory(): void
     {
-        $this->assertIsArray($this->resource->getHistory());
+        // Constructing a resource already records the Ploi instance being set
+        $this->assertNotEmpty($this->resource->getHistory());
     }
 
     public function testAddHistory(): void