ensure tests work with restapi installed - #195
Open
djay wants to merge 3 commits into
Open
Conversation
Member
Author
|
@jenkins-plone-org please run jobs |
Member
|
Thanks for your contribution! |
ale-rt
reviewed
Apr 23, 2021
| def setUpPloneSite(self, portal): | ||
| # install into the Plone site | ||
| applyProfile(portal, 'plone.app.theming:default') | ||
| #if portal.portal_setup.profileExists('plone.restapi:default'): |
ale-rt
reviewed
Apr 23, 2021
| <include package="plone.resourceeditor" /> | ||
| <include package="plone.transformchain" /> | ||
| <include package="plone.app.registry" /> | ||
| <include package="plone.restapi" /> |
Member
There was a problem hiding this comment.
I have some doubt about this line.
Is this change important only for the tests?
In that case I would handle that in the test layer.
And probably add plone.restapi as an extra requirement in the setup.py for the [test] feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug with my previous PR - plone/plone.rest#61. It didn't install plone.restapi so didn't actually test that it works with it installed