Repository navigation
Fix add_annotation and add_shape slowing down cubically as a figure fills up #5779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test coverage is a bit limited. The changelog names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't introduce a batch-mode fallback - it makes the same method behave differently in two contexts. Take this sequence: add annotation A, keep a reference to it, add B, then edit A through the reference. Outside batch_update() the edit shows up. Inside it, the edit is lost. Your description says the fallback can go once #5758 lands. Please either handle batch mode consistently, or coordinate with #5758 so that a "fallback" never merges.