Skip to content

Commit 17c3a54

Browse files
committed
fix: resolve EBADENGINE failures and format CHANGELOG
Exclude Node 18, 19, 21, and 23 for ESLint 10, properly quoting node versions to avoid type mismatch in GitHub Actions matrix exclusions. Dynamically remove eslint-doc-generator before installing eslint 9+ to prevent EBADENGINE failures due to commander@14 requiring Node >=20. Format CHANGELOG.md to place removed support under a ### Breaking heading as per v7.0.0 conventions.
1 parent af068eb commit 17c3a54

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

‎.github/workflows/eslint-9+.yml‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,15 @@ jobs:
3939
typescript-eslint:
4040
- 8
4141
exclude:
42-
# ESLint 10 supports Node.js 20+.
42+
# ESLint 10 supports Node.js ^20.19.0 || ^22.13.0 || >=24
4343
- eslint: 10
44-
node-version: 18
44+
node-version: "18"
4545
- eslint: 10
46-
node-version: 19
46+
node-version: "19"
47+
- eslint: 10
48+
node-version: "21"
49+
- eslint: 10
50+
node-version: "23"
4751
- eslint: 10
4852
babel-eslint: 8
4953

@@ -54,6 +58,7 @@ jobs:
5458
with:
5559
node-version: ${{ matrix.node-version }}
5660
after_install: |
61+
npm remove --no-save eslint-doc-generator
5762
npm install --no-save "eslint@${{ matrix.eslint }}" "@typescript-eslint/parser@${{ matrix.eslint == 10 && 'canary' || (matrix.typescript-eslint == 8 && 8.17 || matrix.typescript-eslint) }}" "babel-eslint@${{ matrix.babel-eslint }}" "typescript@5"
5863
skip-ls-check: true
5964
- run: npx ls-engines

‎CHANGELOG.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
66

77
## Unreleased
88

9+
### Breaking
10+
* Drop support for Node 4 and ESLint 3 and 4 ([#3979][] @plthomasva)
11+
912
### Added
1013
* [`async-server-action`]: add rule ([#3729][] @jorgezreik)
1114
* [`jsx-props-no-multi-spaces`]: improve autofix for multi-line ([#3930][] @justisb)
@@ -27,7 +30,6 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
2730
* Support ESLint v10 by migrating off deprecated AST properties ([#3979][] @plthomasva)
2831

2932
### Changed
30-
* Drop support for Node 4 and ESLint 3 and 4 ([#3979][] @plthomasva)
3133
* [`react-in-jsx-scope`], [`jsx-uses-react`]: automatically disable when React >= 19 is detected ([#XXXX][] @jonkoops)
3234
* [Docs] [`no-array-index-key`]: add template literal examples ([#3978][] @akahoshi1421)
3335

0 commit comments

Comments
 (0)