chore: build 1.0.0-rc6 for testing - #118
Merged
Merged
Conversation
Carries the two fixes that rc5 missed. rc5 was built at 14:14 UTC on 2026-08-17 and #112 merged at 18:30 the same day, so the shim that exists specifically so ChatGPT can discover tools is on main but has never been in a zip — verified absent in dist/saddle-1.0.0-rc5.zip. Also fixes the version task itself. It wrote four of the five places the version lives and skipped package-lock.json entirely, so the lockfile sat at the previous version after every bump. Handled structurally rather than by text substitution: every dependency in that file carries a "version" field too, and a global regex for one would rewrite them all. Changelog entries for #112 and #116 written against 1.0.0 — Stable tag does not move for a release candidate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps to
1.0.0-rc6and fixes the version task, which was skipping one of the five places the version lives.Why
rc5 does not contain the ChatGPT fix. It was built at 14:14 UTC on 2026-08-17; #112 merged at 18:30 the same day. Verified in the artifact:
dist/saddle-1.0.0-rc5.ziphas noclass-saddle-mcp-compat.php. So the shim that exists specifically so ChatGPT can discover tools is onmainand has still never been in anyone's hands — which is the second time that has happened to this same fix.rc6 carries it, plus #116 (the Client traffic card no longer opens with "No app has connected yet" on every build we ship) and #117.
The version task
It wrote the plugin header,
SADDLE_VERSION,readme.txtandpackage.json— and never touchedpackage-lock.json, so the lockfile stayed at the previous version after every bump. CLAUDE.md lists all five as having to agree; four of them did.Fixed structurally, not by text substitution: every dependency in a lockfile carries its own
"version"field, so a global regex for"version": "<semver>"rewrites all of them to the plugin's version. This setslock.versionandlock.packages[''].versionand nothing else — verified as a 2-line diff with no dependency churn.Changelog
Entries for #112 and #116 added under
= 1.0.0 =in customer-facing language.Stable tagstays at1.0.0— it never moves for a release candidate.Testing
composer test— 596 tests, greencomposer lint— 0 errors;npm run lint:jscleanphp scripts/revendor-wp-mcp.php --check— clean, exit 0includes/lib(three matches are the word "system" inside translated prose)Stable tagcorrectly held at1.0.0.org-selfhostedclass-saddle-mcp-compat.phpclass-saddle-updater.phplib/wp-mcpclass-saddle-ecosystem.phptests/,dist/,*.mdadmin/build/index.js,record_healthinincludes/class-saddle-mcp.php./scripts/release.shis a separate, outward-facing step and is Fahim's call.