chore(oauth): annotate core rest_url filter for Plugin Check - #130
Merged
Conversation
Plugin Check's prefix sniff flags applying a filter named rest_url. It is core's own filter, applied with core's argument shape so the pre-init replica stays byte-identical to get_rest_url() — annotate rather than rename. Refs #127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One phpcs:ignore comment, no behavior change. Plugin Check (run against the built 1.0.0 zip for the .org submission) warns that
apply_filters( 'rest_url', … )in the newrest_url_early()is a non-prefixed hook name. It is core's own filter, applied deliberately with core's exact argument shape so the pre-initreplica stays byte-identical toget_rest_url()(see #127 / #128). The annotation states that so the warning disappears from the submission scan.Verified:
composer lintclean; re-ran Plugin Check on the rebuilt zip — therest_urlwarning is gone, only the two pre-existing warnings (vendored adapter hook in mcp-compat, dynamic hooks in the integration engine) remain.🤖 Generated with Claude Code
https://claude.ai/code/session_016dGNUUe36hKi5o9hzFb3Cb