fix: get-instructions description matches its tier-gated payload (#132) - #133
Merged
Merged
Conversation
…ayload The behavior shipped in #87 — plugin inventory rides the context only at the admin tier — but the description still promised "its setup and active plugins" unconditionally, and that line is what the WordPress.org reviewer quoted. Descriptions are the agent-facing interface; this one now states the tier condition. Regenerating the pot also picks up the cookbook strings it had gone stale against — the exact missing-feature failure CLAUDE.md warns about. Refs #132
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #132
What
Rewords the
saddle/get-instructionsdescription so it no longer promises "active plugins" unconditionally — the payload has been admin-tier-gated since #87, and the stale description is the exact line the WordPress.org reviewer quoted. Regenerateslanguages/saddle.pot, which also recovers theclass-saddle-cookbook.phpstrings it had gone stale against.Why
WordPress.org review R saddle/badhonrocks/25Jul26/T2 flagged read-tier exposure of the plugin inventory via get-instructions. The code fix already shipped (#87, with an in-code comment crediting the reviewer); this closes the description half so neither an agent nor the next review pass is misled.
Testing
composer test— 612 tests green (1 pre-existing skip); no CI on this repo, results are from a local runwp i18n make-pot . languages/saddle.pot --exclude=docs,tests,dist,node_modules,scripts,admin/src— verified byte-equivalent msgid set to the committed pot apart from the reworded string and the cookbook additions🤖 Generated with Claude Code
https://claude.ai/code/session_016dGNUUe36hKi5o9hzFb3Cb