Commit aa7b8d7
fix(app): rebase onto main, re-home debug-mode watchdog into the #312 quit drain
Rebases wave-1-debug-diag onto origin/main now that #310-#316 merged
(#312's quit-path restructuring in particular). Structural follow-up:
- The debug-logging-mode watchdog (debug_mode.rs) previously used the
detached memlog.rs pattern (no shutdown tracking). #312 replaced the
old shutdown_orchestrators() with a proper ShutdownHandles/
drain_shutdown_handles structure that every other periodic background
task (updater, telemetry, iostat, and now #311's bottleneck sampler)
registers into for a no-orphan quit drain. Re-homed the watchdog into
that same structure: a new DebugModeRuntime (task + shutdown watch,
no shared hub - the watchdog only reads/writes settings directly)
on AppState, set_debug_mode_task/shutdown_debug_mode_task mirroring
set_bottleneck_task/shutdown_bottleneck_task exactly, a debug_mode
field on ShutdownHandles, and spawn_watchdog now runs the same
select!-on-shutdown-or-tick loop bottleneck_hub/iostat_hub use
instead of a bare loop.
- Added app_state::tests::debug_mode_runtime_task_and_shutdown_round_trip,
mirroring bottleneck's round-trip test.
- privacy.png (light+dark) and 9 shell.spec.ts baselines (light+dark)
regenerated via `just visual-update` (Docker) - the shell baselines
drifted independently of this PR's own diff (same delta across every
scenario in both themes), consistent with normal headless-Chromium
rendering drift between visual-update runs; all 106 visual specs pass
against the regenerated set.
No other conflicts: README.md, dtos.rs, settings.rs's redaction code,
en-US.json, Activity.vue, and fixtures.ts all auto-merged cleanly with
#311's bottleneck-tile additions coexisting alongside this PR's debug
logging toggle and diagnostic-bundle changes.
Verified after rebase: cargo test -p driven-app --lib (494 passed),
cargo clippy --workspace --all-targets -- -D warnings (clean),
cargo fmt --all --check (clean), pnpm lint (0 errors), pnpm format:check
(clean), pnpm test:unit (861 passed, 64 files), pnpm build / vue-tsc
(clean).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xKUm9vH4ifb5LHR5szy1v1 parent c34856a commit aa7b8d7
21 files changed
Lines changed: 38 additions & 1 deletion
File tree
- src-tauri/src
- ui/e2e-visual/__screenshots__/linux
- dark
- settings.spec.ts
- shell.spec.ts
- light
- settings.spec.ts
- shell.spec.ts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
312 | | - | |
| 312 | + | |
313 | 313 | | |
314 | 314 | | |
315 | 315 | | |
| |||
2180 | 2180 | | |
2181 | 2181 | | |
2182 | 2182 | | |
| 2183 | + | |
| 2184 | + | |
| 2185 | + | |
| 2186 | + | |
| 2187 | + | |
| 2188 | + | |
| 2189 | + | |
| 2190 | + | |
| 2191 | + | |
| 2192 | + | |
| 2193 | + | |
| 2194 | + | |
| 2195 | + | |
| 2196 | + | |
| 2197 | + | |
| 2198 | + | |
| 2199 | + | |
| 2200 | + | |
| 2201 | + | |
| 2202 | + | |
| 2203 | + | |
| 2204 | + | |
| 2205 | + | |
| 2206 | + | |
| 2207 | + | |
| 2208 | + | |
| 2209 | + | |
| 2210 | + | |
| 2211 | + | |
| 2212 | + | |
| 2213 | + | |
| 2214 | + | |
| 2215 | + | |
| 2216 | + | |
| 2217 | + | |
| 2218 | + | |
| 2219 | + | |
2183 | 2220 | | |
2184 | 2221 | | |
2185 | 2222 | | |
| |||
0 commit comments