Skip to content

Derive the diagnostic bundle's pending-op field list from the typed payload #284

Description

@pmaxhogan

Context

build_pending_ops_summary (src-tauri/src/commands/settings.rs) hand-parses pending-op payload JSON with a hardcoded flag list, because PendingOpPayload is private to driven-core::executor.

Cross-reference comments exist on both sides today to keep the two in sync manually, but drift has already happened once: client_op_uuid was missing from the hand-parsed list until PR #279's final commit added it.

Ask

Expose the PendingOpPayload struct (or a purpose-built pub summary view) from driven-core, so build_pending_ops_summary derives its field list from the single source of truth in driven-core::executor instead of a hand-maintained parallel list in src-tauri.

Reference

PR #279 (fix(core): stream the resumable-upload resume instead of buffering the whole file) - deferred hardening item from its multi-agent review, which found and fixed the client_op_uuid drift.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    • Status
      Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions