fix(deps): bump tauri-winrt-notification to drop vulnerable quick-xml (closes #89) - #129
Merged
Merged
Conversation
Contributor
Coverage
Gate: passed - no coverage regression (epsilon 0.1 pp). |
pmaxhogan
enabled auto-merge (squash)
July 20, 2026 15:31
closes #89) quick-xml 0.37.5, pulled in transitively via quick-xml <- tauri-winrt-notification 0.7.2 <- notify-rust <- tauri-plugin-notification <- driven-app, was vulnerable to RUSTSEC-2026-0194 and RUSTSEC-2026-0195. tauri-winrt-notification 0.7.3 (published on crates.io, semver-compatible with notify-rust's existing ^0.7 requirement) dropped the quick-xml dependency entirely (tauri-apps/winrt-notification#53), so a plain `cargo update -p tauri-winrt-notification` removes the vulnerable copy from the tree without any [patch.crates-io] override or code change. The other vulnerable copy (via plist <- tauri-utils) was already resolved on main via a routine dependabot bump to plist 1.10.0 (quick-xml 0.41.0). Remove the two now-unused RUSTSEC-2026-0194 / RUSTSEC-2026-0195 ignores from deny.toml. Closes #89 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QZQVP2tUuTLh8oL31D8heC
pmaxhogan
force-pushed
the
fix/quick-xml-rustsec-89
branch
from
July 20, 2026 17:18
bbf0f59 to
c0e0613
Compare
pmaxhogan
added a commit
that referenced
this pull request
Jul 24, 2026
🤖 I have created a release *beep* *boop* --- ## [2.1.0](v2.0.1...v2.1.0) (2026-07-24) ### Features * **core:** adaptive upload parallelism with throughput probe and disk-saturation gate ([#143](#143)) ([8ecced6](8ecced6)) * **core:** filesystem timestamp-granularity probe with ctime fallback and per-directory gitignore cascade ([#141](#141)) ([344262c](344262c)) * **drive:** support Google Shared Drive destinations end-to-end ([#142](#142)) ([d9c3161](d9c3161)) * **net:** native OS reachability backends with automatic fallback ([#138](#138)) ([319e85f](319e85f)) * **net:** SOCKS5 and PAC proxy support for all outbound connections ([#145](#145)) ([2f0b7d1](2f0b7d1)) * **net:** support a custom corporate root CA for all outbound connections ([#134](#134)) ([929e93d](929e93d)) * per-source toggle to back up OneDrive cloud-only placeholder files ([#133](#133)) ([6863ea3](6863ea3)) * **telemetry:** capture latency percentiles and add rollup query endpoint ([#132](#132)) ([4e9fde6](4e9fde6)) * **telemetry:** preview exactly what a telemetry ping sends ([#139](#139)) ([95fbd9a](95fbd9a)) ### Bug Fixes * **core:** commit file_state for a create that skipped post-upload so the next scan updates instead of re-creating ([#146](#146)) ([f5230d1](f5230d1)) * **deps:** bump tauri-winrt-notification to drop vulnerable quick-xml (closes [#89](#89)) ([#129](#129)) ([232fd8f](232fd8f)) * **telemetry:** exclude pre-schema rows from latency rollup ([#137](#137)) ([1ae6220](1ae6220)) * **ui:** add cursor pointer to buttons and link-buttons ([#136](#136)) ([dbd4809](dbd4809)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #89.
cargo deny checkwas ignoring two quick-xml DoS advisories(RUSTSEC-2026-0194, RUSTSEC-2026-0195) against
quick-xml 0.37.5, pulled invia:
No
[patch.crates-io]override was needed.tauri-winrt-notification 0.7.3was published to crates.io on 2026-07-02 and drops the quick-xmldependency entirely (upstream: tauri-apps/winrt-notification#53, "Drop
quick-xml dependency"). 0.7.3 is semver-compatible with notify-rust's
existing
^0.7requirement, so this is a plaincargo update -p tauri-winrt-notificationlockfile bump - no[patch.crates-io]block, nogit-source pin, no code change. (The issue was filed assuming 0.7.2 was
notify-rust's latest available bump target and that a semver-major jump to
0.8.x, or an upstream notify-rust release, would be required - that's no
longer the case now that 0.7.3 exists.)
The other vulnerable copy noted in the issue (
quick-xml 0.39.4 <- plist 1.9.0 <- tauri-utils) was already resolved onmainprior to this PR via aroutine dependabot bump to
plist 1.10.0(quick-xml^0.41).cargo tree -i quick-xml
Before:
After:
The vulnerable
quick-xml 0.37.5copy is gone from the tree entirely; onlythe already-fixed
quick-xml 0.41.0(>= the 0.41.0 threshold bothadvisories are fixed in) remains.
Changes
Cargo.lock:tauri-winrt-notification0.7.2 -> 0.7.3 (drops itsquick-xmldependency;Cargo.tomlis unchanged).deny.toml: remove the now-unusedRUSTSEC-2026-0194/RUSTSEC-2026-0195ignore entries and their justification comment.Verification
cargo deny check: advisories ok, bans ok, licenses ok, sources ok.cargo check --workspace: green (covers the Windows-onlytauri-winrt-notificationnotification path on this Windows host).cargo test -p driven-app --lib: 228 passed, 0 failed.Test plan
cargo tree -i quick-xmlshows noquick-xml < 0.41.0in the treecargo deny checkis green with the two RUSTSEC ignores removedcargo check --workspacecompiles cleancargo test -p driven-app --libpassesCloses #89
🤖 Generated with Claude Code
https://claude.ai/code/session_01QZQVP2tUuTLh8oL31D8heC