fix(ui): label bundle_upload and hook activity event types - #154
Merged
Merged
Conversation
The activity event-type dropdown and table rendered raw snake_case codes for bundle_upload, hook.pre, and hook.post because they had no entry under activity.events. Also converts the dotted flat keys (local.*) to proper nesting: vue-i18n splits lookup keys on dots, so the flat dotted keys never resolved and only worked by accident via the identical errors.*.short fallback chain. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JLB3E2Jm7knNJd37fVpH8X
Contributor
Coverage
Gate: passed - no coverage regression (epsilon 0.1 pp). |
pmaxhogan
added a commit
that referenced
this pull request
Jul 25, 2026
🤖 I have created a release *beep* *boop* --- ## [2.3.0](v2.2.0...v2.3.0) (2026-07-25) ### Features * **core:** record a backup_done activity row when a run completes ([#160](#160)) ([90cde5c](90cde5c)) * **ui:** files-uploaded stat card with sparkline and smoother Activity load-in ([#157](#157)) ([2d85c99](2d85c99)) * **ui:** live streaming folder-tree preview for the exclusion editor ([#158](#158)) ([47ebe14](47ebe14)) ### Bug Fixes * **telemetry:** count bundled uploads in the anonymous aggregate ([#159](#159)) ([11af7ea](11af7ea)) * **ui:** label bundle_upload and hook activity event types ([#154](#154)) ([2998c76](2998c76)) * **ui:** make the backing-up bar a true determinate progress bar ([#155](#155)) ([eed80a6](eed80a6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundle_upload,hook.pre, andhook.postbecause none of them had an entry underactivity.eventsin the locale file.bundle_upload-> "Uploaded (bundled)",hook.pre-> "Pre-backup hook",hook.post-> "Post-backup hook"."local.unicode_collision"etc.) NEVER resolved - vue-i18n splits lookup keys on dots, so those flat keys were dead and only rendered correctly by accident via the identicalerrors.<code>.shortfallback chain. They are now proper nested objects (rendered strings unchanged). This is also why a naive flat"hook.pre"key silently fails - there is no errors fallback for hooks.Testing
activity-event-label.test.tswith assertions for all three new labels (thehook.*ones fail against flat dotted keys, proving the nesting matters).🤖 Generated with Claude Code
https://claude.ai/code/session_01JLB3E2Jm7knNJd37fVpH8X