fix(telemetry): count bundled uploads in the anonymous aggregate - #159
Merged
Merged
Conversation
telemetry_events_since counted only upload_done rows via COUNT(*), so a bundle_upload row (one row, N member files, the packed object's bytes) was invisible to telemetry - the same undercount #157 fixed for the dashboard summary and throughput series. Align on the shared upload-row definition: event_type IN ('upload_done','bundle_upload') with SUM(COALESCE(file_count, 1)) for files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JLB3E2Jm7knNJd37fVpH8X
Contributor
Coverage
Gate: passed - no coverage regression (epsilon 0.1 pp). |
pmaxhogan
added a commit
that referenced
this pull request
Jul 25, 2026
🤖 I have created a release *beep* *boop* --- ## [2.3.0](v2.2.0...v2.3.0) (2026-07-25) ### Features * **core:** record a backup_done activity row when a run completes ([#160](#160)) ([90cde5c](90cde5c)) * **ui:** files-uploaded stat card with sparkline and smoother Activity load-in ([#157](#157)) ([2d85c99](2d85c99)) * **ui:** live streaming folder-tree preview for the exclusion editor ([#158](#158)) ([47ebe14](47ebe14)) ### Bug Fixes * **telemetry:** count bundled uploads in the anonymous aggregate ([#159](#159)) ([11af7ea](11af7ea)) * **ui:** label bundle_upload and hook activity event types ([#154](#154)) ([2998c76](2998c76)) * **ui:** make the backing-up bar a true determinate progress bar ([#155](#155)) ([eed80a6](eed80a6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telemetry_events_sincecounted onlyupload_donerows viaCOUNT(*), sobundle_uploadrows (N member files each) were invisible to anonymous telemetry - the same undercount class feat(ui): files-uploaded stat card with sparkline and smoother Activity load-in #157 fixed for the dashboard summary and throughput series.event_type IN ('upload_done','bundle_upload')withSUM(COALESCE(file_count, 1))for files; bytes sum both types..sqlxoffline cache regenerated (just sqlx-preparesteps).Testing
telemetry_events_since_aggregates_uploads_errors_and_deep_verifywith in-window, pre-window, and future-datedbundle_uploadrows (in-window bundle of 5 files counts as 5; window bounds still apply).cargo test -p driven-core --libtelemetry test green;cargo test -p driven-app --lib telemetry31/31; clippy clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01JLB3E2Jm7knNJd37fVpH8X