docs: clarify changelog/versioning rules + fix release-please token comment - #42
Merged
Merged
Conversation
…omment Apply review follow-ups on the PR-title/release-please guidance: - CLAUDE.md: changelog-visible types also include revert + deps (not just feat/fix/perf); warn that mislabeling a real change as a hidden type (chore/docs/...) passes the title gate but still drops it from the release notes - the #37 failure mode, self-inflicted. - CLAUDE.md: state that a breaking change pre-1.0 bumps minor (0.x.0), not major, under bump-minor-pre-major. - CLAUDE.md: note squash is the only enabled merge method (why branch commit messages don't need to be conventional). - release-please.yml: correct the stale comment - RELEASE_PLEASE_TOKEN IS set, which is what lets pull_request checks (incl. the title gate) run on the release PR despite GitHub's GITHUB_TOKEN recursion guard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017GadVxaYAAY1Q5tRMNucrM
Contributor
Coverage
Gate: passed - no coverage regression (epsilon 0.1 pp). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up polish from the review of the PR-title enforcement work (the gate itself shipped in #39; v0.3.0 is already released). No behavior change - docs + one workflow comment.
Changes
feat/fix/perf/revert/deps, not justfeat/fix/perf.chore:/docs:/ci:/...) passes the title gate but still produces no changelog entry / no version bump - the Comprehensive UI/UX overhaul + tray i18n/icon fix + CLI tests #37 "silently dropped" failure, self-inflicted. Pick the accurate type.bump-minor-pre-major)..github/workflows/release-please.yml- correct the stale comment:RELEASE_PLEASE_TOKENis configured, which is what letspull_requestchecks (incl. theValidate PR titlegate) run on the release PR despite GitHub'sGITHUB_TOKENrecursion guard.🤖 Generated with Claude Code