test(chaos): fix NTFS volume probe so Windows hazard scenarios run - #68
Merged
Merged
Conversation
probe_ntfs_volume read the drive letter from the first char of the RELATIVE fixture path "target/chaos-fixtures" (-> 't' -> a nonexistent T:\ ), so cap:ntfs_volume was never set and every NTFS hazard scenario silently skipped on Windows and in CI. Resolve the fixture root to an absolute path so the probe reads the real drive letter. Locally run-all goes 61 -> 74 scenarios actually executed (ADS, junctions, reparse, sparse/compressed/EFS, hardlinks, reserved names), 0 real failures. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UBkoioGf5QscNHccKyhQj2
Contributor
Coverage
Gate: passed - no coverage regression (epsilon 0.1 pp). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chaos harness's NTFS-volume capability probe read the drive letter from the first character of a relative fixture path (
target/chaos-fixtures->t-> a nonexistentT:\), socap:ntfs_volumewas never detected and every NTFS hazard scenario silently skipped on Windows and in CI -- thechaos hermetic/chaos fake-drive (windows-latest)jobs were green while exercising none of them.Fix: resolve the fixture root to an absolute path so the probe reads the real drive letter (
C:).Verified locally:
run-allgoes from 61 -> 74 scenarios actually executed (ADS, junctions, reparse points, recursive junction cycles, sparse/compressed/EFS files, hardlinks, reserved/surrogate names), 0 real failures. Surfaced while running the #23 crypto/restore soak natively on Windows.🤖 Generated with Claude Code