docs(docker): keep managed Node visible with BuildKit cache mounts - #884
docs(docker): keep managed Node visible with BuildKit cache mounts#884MHJahanbakhsh wants to merge 1 commit into
Conversation
Mount the pnpm store cache at a path other than /pnpm/store and pass --store-dir, so `pnpm runtime set … -g` Node under the default store is not hidden during install. Fixes pnpm#880.
|
|
|
@MHJahanbakhsh is attempting to deploy a commit to the pnpm Team on Vercel. A member of the Team first needs to authorize it. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 2 reviews per rolling hour; 1 remains after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
|
| Layer / File(s) | Summary |
|---|---|
Separate cache mount from managed runtime docs/docker.md |
The guide documents the /pnpm/store default, warns about globally managed Node.js, and updates both Docker examples to use /var/cache/pnpm for dependency caching. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Merge Risk: ⚪ Minimal · up to b4302
This is a localized Docker documentation change with no actionable merge-blocking risk remaining after normal checks and review.
Suggested reviewers: zkochan
Poem
A rabbit hops where cache paths gleam,
Keeping Node awake inside the stream.
/var/cache/pnpmnow marks the way,
While/pnpm/storestays safe each day.
Docker builds can run and play.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check | ✅ Passed | The documentation changes address issue #880 by moving the cache mount and store directory away from the managed Node runtime. |
| Out of Scope Changes check | ✅ Passed | The changes are limited to Docker documentation and directly support the linked issue objectives. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly describes the Docker documentation change that keeps the managed Node runtime visible with BuildKit cache mounts. |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Confidence Score: 5/5The PR appears safe to merge; the revised examples preserve the managed Node runtime while retaining pnpm package caching. The cache target and explicit store directory are aligned in every changed install command, and the documented workaround addresses the store-overlay failure without introducing a supported-path regression. Reviews (1): Last reviewed commit: "docs(docker): keep managed Node visible ..." | Re-trigger Greptile |
Summary
/pnpm/storehide Node installed viapnpm runtime set … -g, because the managed runtime lives under that store./var/cache/pnpmand pass--store-dir /var/cache/pnpm, so the default store (andnodeonPATH) stay available duringpnpm install./pnpm/storemust not be used as the cache mount target when using the managed runtime.Test plan
node --versionworking inside a cache-mountedRUN