feat(blocks): add text2speech/translate/videoSensing block factories by nakasyou · Pull Request #153 · pnsk-lab/hikkaku

nakasyou · 2026-04-27T13:17:16Z

Motivation

Provide built-in block factories for several Scratch default extensions so Hikkaku can emit the corresponding extension opcodes and be used by higher-level tools and tests.
Improve test coverage and documentation generation for these extension-like blocks.

Description

Add packages/hikkaku/src/blocks/text2speech.ts, translate.ts, and videosensing.ts providing block factories for text2speech_*, translate_*, and videoSensing_* opcodes respectively.
Add focused unit tests text2speech.test.ts, translate.test.ts, and videosensing.test.ts that assert the expected opcodes are emitted when blocks are composed.
Export the new modules from packages/hikkaku/src/blocks/index.ts so they are available from the public blocks entrypoint.
Use type-friendly signatures (PrimitiveSource<HikkakuString> / PrimitiveSource<HikkakuNumber>) to satisfy existing HikkakuType constraints and avoid unconnected value-block test errors.

Testing

Ran bun fmt to apply formatting and fixes (successful).
Ran bun run typecheck && bun run test in packages/hikkaku, and all tests passed (50 tests across 27 files).
Ran bun ref:build to update reference docs (successful); note that a full repo-level bun typecheck previously failed in this environment because moon is not installed when building packages/moonscratch, which is environment-specific and unrelated to these package changes.

Codex Task

…locks Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>

codecov · 2026-04-27T13:18:44Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   80.72%   80.80%   +0.08%     
==========================================
  Files          50       53       +3     
  Lines        4083     4101      +18     
  Branches      590      590              
==========================================
+ Hits         3296     3314      +18     
  Misses        549      549              
  Partials      238      238

Flag	Coverage Δ
tests	`80.80% <100.00%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/hikkaku/src/blocks/text2speech.ts	`100.00% <100.00%> (ø)`
packages/hikkaku/src/blocks/translate.ts	`100.00% <100.00%> (ø)`
packages/hikkaku/src/blocks/videosensing.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nakasyou · 2026-04-27T13:19:58Z

@Kicky1618 review

Copilot

Pull request overview

Adds first-class block factory helpers for several Scratch “default extension” opcodes (Text to Speech, Translate, Video Sensing) so hikkaku/blocks can emit those blocks directly and so they’re covered by unit tests and docs generation.

Changes:

Added new block factory modules: text2speech, translate, videosensing
Added unit tests asserting the expected extension opcodes are emitted
Re-exported the new modules from the public blocks entrypoint

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
packages/hikkaku/src/blocks/videosensing.ts	Implements Video Sensing block factories (including a hat-like block).
packages/hikkaku/src/blocks/videosensing.test.ts	Verifies Video Sensing opcodes appear in composed block output.
packages/hikkaku/src/blocks/translate.ts	Implements Translate reporter block factories.
packages/hikkaku/src/blocks/translate.test.ts	Verifies Translate opcodes appear in composed block output.
packages/hikkaku/src/blocks/text2speech.ts	Implements Text to Speech statement block factories.
packages/hikkaku/src/blocks/text2speech.test.ts	Verifies Text to Speech opcodes appear in composed block output.
packages/hikkaku/src/blocks/index.ts	Exposes the new modules via the public `hikkaku/blocks` entrypoint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-27T13:23:48Z

+export const translate = (
+  words: PrimitiveSource<HikkakuString>,
+  language: PrimitiveSource<HikkakuString>,
+) => {
+  return valueBlock<HikkakuString>('translate_getTranslate', {
+    inputs: {
+      WORDS: fromPrimitiveSource(InputType.String, words, 'hello'),
+      LANGUAGE: fromPrimitiveSource(InputType.String, language, 'ja'),
+    },
+  })


translate_getTranslate’s LANGUAGE argument is typically a dropdown/menu in Scratch, but here it’s represented as a plain string input. Elsewhere, dropdowns are modeled as fields or menuInput with a shadow menu block (e.g. sensing_keypressed). Consider aligning with that approach so generated SB3 retains expected menu/shadow structure and callers get clearer intent.

Copilot · 2026-04-27T13:23:48Z

+export const translate = (
+  words: PrimitiveSource<HikkakuString>,
+  language: PrimitiveSource<HikkakuString>,
+) => {
+  return valueBlock<HikkakuString>('translate_getTranslate', {
+    inputs: {
+      WORDS: fromPrimitiveSource(InputType.String, words, 'hello'),
+      LANGUAGE: fromPrimitiveSource(InputType.String, language, 'ja'),
+    },
+  })
+}


This new module’s public exports are missing JSDoc comments, while most existing block factories in this directory include structured JSDoc used for reference docs/examples (see blocks/looks.ts, blocks/music.ts, etc.). Adding doc comments here would keep the generated docs consistent with the rest of the blocks API.

Copilot · 2026-04-27T13:23:49Z

+export const whenMotionGreaterThan = (
+  reference: PrimitiveSource<HikkakuNumber>,
+) => {
+  return block('videoSensing_whenMotionGreaterThan', {
+    inputs: {
+      REFERENCE: fromPrimitiveSource(InputType.Number, reference, 10),
+    },
+  })
+}


This new module adds public block factories but does not include the JSDoc-style documentation used throughout packages/hikkaku/src/blocks (inputs/outputs + @example). Since the PR mentions documentation generation, consider adding JSDoc for these exports to match the rest of the blocks API.

Copilot · 2026-04-27T13:23:49Z

+export const whenMotionGreaterThan = (
+  reference: PrimitiveSource<HikkakuNumber>,
+) => {
+  return block('videoSensing_whenMotionGreaterThan', {
+    inputs: {
+      REFERENCE: fromPrimitiveSource(InputType.Number, reference, 10),
+    },
+  })


videoSensing_whenMotionGreaterThan is a hat block in Scratch, but this factory creates it as a normal statement (no topLevel: true and no stack attachment). This can lead to invalid scripts (hat blocks chained under another block) and prevents the block from being used like other hat helpers (e.g. whenFlagClicked). Consider adding topLevel: true and an optional stack?: () => void parameter using attachStack (as done in blocks/events.ts).

Copilot · 2026-04-27T13:23:49Z

+  attribute: PrimitiveSource<HikkakuString>,
+  subject: PrimitiveSource<HikkakuString>,
+) => {
+  return valueBlock<HikkakuNumber>('videoSensing_videoOn', {
+    inputs: {
+      ATTRIBUTE: fromPrimitiveSource(InputType.String, attribute, 'motion'),
+      SUBJECT: fromPrimitiveSource(InputType.String, subject, 'this sprite'),


These dropdown-like parameters (ATTRIBUTE, SUBJECT) are currently encoded as plain string inputs via fromPrimitiveSource. Elsewhere in this codebase, menu/dropdown inputs are typically modeled with menuInput(...) + a shadow menu reporter block (see sensing.getKeyPressed / menuOfKeyOptions) or as fields when the value is a true field. Encoding this as a primitive string input may lose the expected menu shadow block / UI semantics in generated SB3. Consider switching to a menu helper (or fields) consistent with other dropdowns.

Suggested change

attribute: PrimitiveSource<HikkakuString>,

subject: PrimitiveSource<HikkakuString>,

) => {

return valueBlock<HikkakuNumber>('videoSensing_videoOn', {

inputs: {

ATTRIBUTE: fromPrimitiveSource(InputType.String, attribute, 'motion'),

SUBJECT: fromPrimitiveSource(InputType.String, subject, 'this sprite'),

attribute: VideoSensingAttribute,

subject: VideoSensingSubject,

) => {

return valueBlock<HikkakuNumber>('videoSensing_videoOn', {

fields: {

ATTRIBUTE: [attribute, null],

SUBJECT: [subject, null],

Copilot · 2026-04-27T13:23:49Z

+export const videoToggle = (state: PrimitiveSource<HikkakuString>) => {
+  return block('videoSensing_videoToggle', {
+    inputs: {
+      VIDEO_STATE: fromPrimitiveSource(InputType.String, state, 'on'),


VIDEO_STATE is a dropdown in Scratch, but it is currently represented as a generic string input. To match other dropdown/menu patterns in this repo (and Scratch’s SB3 structure), consider modeling this as fields: { VIDEO_STATE: [...] } or via menuInput + a shadow menu reporter block, rather than fromPrimitiveSource(InputType.String, ...).

Suggested change

export const videoToggle = (state: PrimitiveSource<HikkakuString>) => {

return block('videoSensing_videoToggle', {

inputs: {

VIDEO_STATE: fromPrimitiveSource(InputType.String, state, 'on'),

export const videoToggle = (state: VideoState) => {

return block('videoSensing_videoToggle', {

fields: {

VIDEO_STATE: [state, null],

Copilot · 2026-04-27T13:23:50Z

+export const speakAndWait = (words: PrimitiveSource<HikkakuString>) => {
+  return block('text2speech_speakAndWait', {
+    inputs: {
+      WORDS: fromPrimitiveSource(InputType.String, words, 'hello'),
+    },
+  })


The exported block factories in this new module are missing the JSDoc pattern used across packages/hikkaku/src/blocks (description, inputs/outputs, @example, etc.), which is likely important for the reference doc generation mentioned in the PR description. Consider adding doc comments for the public exports (similar to music.ts / looks.ts) so generated docs remain consistent.

Copilot · 2026-04-27T13:23:50Z

+export const setVoice = (voice: PrimitiveSource<HikkakuString>) => {
+  return block('text2speech_setVoice', {
+    inputs: {
+      VOICE: fromPrimitiveSource(InputType.String, voice, 'ALTO'),
+    },
+  })


TextToSpeechVoice is declared, but setVoice accepts PrimitiveSource<HikkakuString> and encodes VOICE as a generic string input. If this block is meant to reflect Scratch’s voice dropdown, consider using the TextToSpeechVoice type in the API (and encoding as a dropdown via fields or menuInput + a shadow menu block) so callers get type safety and the generated SB3 better matches Scratch semantics.

feat(blocks): add text2speech translate and video sensing extension b…

db71713

…locks Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com>

Copilot AI review requested due to automatic review settings April 27, 2026 13:17

nakasyou added the codex label Apr 27, 2026 — with ChatGPT Codex Connector

Copilot started reviewing on behalf of nakasyou April 27, 2026 13:17 View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

nakasyou closed this Apr 27, 2026

Navigation Menu

Uh oh!

feat(blocks): add text2speech/translate/videoSensing block factories - #153

feat(blocks): add text2speech/translate/videoSensing block factories#153
nakasyou wants to merge 1 commit into
mainfrom
codex/resolve-issue-151

nakasyou commented Apr 27, 2026

Uh oh!

codecov Bot commented Apr 27, 2026 •

edited

Loading

Uh oh!

nakasyou commented Apr 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

Copilot AI Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nakasyou commented Apr 27, 2026

Motivation

Description

Testing

Uh oh!

codecov Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nakasyou commented Apr 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Apr 27, 2026 •

edited

Loading