Skip to content

Remove spark - #37

Open
MattWellie wants to merge 7 commits into
mainfrom
no-spark
Open

MattWellie wants to merge 7 commits into
mainfrom
no-spark

Conversation

@MattWellie

Copy link
Copy Markdown
Collaborator

This is a very low priority

Purpose

  • To remove Spark/Hail from Talos, I also have to remove Hail/Spark from all the dependencies

Proposed Changes

  • Creates a new version of clinvarbitration, removing all hail interactions. VCFs are written manually instead of using HT -> VCF export, and the PM5 Hail Table is replaced with a JSON lookup
  • No impact on current versions of Talos, the dependency pin will tolerate all minor version bumps, but this is a a major

Checklist

  • Related GitHub Issue created
  • Tests covering new change
  • Linting checks pass
  • Bump the version number with bump2version

@@ -10,8 +10,6 @@ include { ResummariseRawSubmissions } from './modules/ResummariseRawSubmissions/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead-code: check_params() is still defined at line 63 of the same file but has no remaining callers after this deletion.

@cassimons cassimons left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants