Skip to content

Potential Combiner Bug #1258

Description

@MattWellie

Recent addition: removal of samples from VDS before combining additional content

Possible bug: 'continuation' from a previous VDS, but no common samples. Probably the result of an error in cohort spec

Manifests as:

  • removes all samples from existing VDS, writes empty content
  • combiner starts, but fails to calculate anything using vds.n_samples which is None? 0?
...
self._vdses[max(1, floor(log(vds.n_samples, self._branch_factor)))].append(vds)
   ValueError: math domain error

https://batch.hail.populationgenomics.org.au/batches/618867/jobs/1

Solution: If a removal of samples would remove all the samples, don't action, error out instead

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions