Skip to content

Fix cohort.get_sequencing_groups in cpg_workflows targets.py - #899

Draft
EddieLF wants to merge 5 commits into
mainfrom
cohort_get_sgs_fix
Draft

EddieLF wants to merge 5 commits into
mainfrom
cohort_get_sgs_fix

Conversation

@EddieLF

@EddieLF EddieLF commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Sep 11, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.45%. Comparing base (3d7b16c) to head (419b10d).
⚠️ Report is 376 commits behind head on main.

Files with missing lines Patch % Lines
cpg_workflows/targets.py 50.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #899       +/-   ##
===========================================
- Coverage   78.50%   53.45%   -25.06%     
===========================================
  Files          10       10               
  Lines        1791     1811       +20     
===========================================
- Hits         1406      968      -438     
- Misses        385      843      +458     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MattWellie

Copy link
Copy Markdown
Contributor

I think this is also close-able WRT #959, which guts all crossover between Cohorts and Datasets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants