docs(adr): 0009 — comments are sent, not dumped: a two-way review loop (proposed) - #48
Merged
Merged
Conversation
…p (proposed) A comment is a draft until the reviewer sends it, delivered once the counterpart holds it; Claude is the counterpart in review mode, reached by a detached server and a re-armed background --wait, and answers into the thread; GitHub is the counterpart in PR mode, through a pending review and a Submit with a verdict. Done, the modal and --yes go; the tab closing ends a session. The review follows the code as the last slice. Settled in a grilling session; resolves #20 once built. Glossary gains the lifecycle terms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed ADR for #20, merged before the work per the rule in the ADR index. Settled in a grilling session; the decision tree is in the ADR's Decision and Alternatives sections.
scr reviewdetaches; Claude runsscr review --wait <run_id>in the background and is woken per batch;scr comment reply/resolveanswers into the thread live; the tab closing ends the session; the review follows the code (last slice).--yesgo; Claude stays out.docs/slices/two-way-review-loop.md(three slices, gated).