fix(structural): the symbol delta of a dirty tree reads the worktree, not the head token - #50
Merged
Merged
Conversation
… not the head token A dirty-tree review's head is the working directory; its token (<sha>-dirty-<hash>) is no revision, and compute_symbol_delta named it to git diff, which failed the overview pass on every dirty tree since #22. Changed paths now come from the head worktree — git diff against the base plus the untracked files, as grep already sees them — which serves a committed head the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-existing since #22, surfaced by a dirty checkout:
compute_symbol_deltapassed the synthetic<sha>-dirty-<hash>head token togit diff --name-only, so the overview pass failed on any review of an uncommitted tree. Changed paths now come from the head worktree (git diff --name-only <base>in it, plusls-files --others --exclude-standard— the untracked filesgit grep --untrackedalready sees), which serves a committed head identically. Test covers a modified tracked file and a new untracked one under a dirty token.