Copilot/fix build error in application - #98
Merged
Conversation
… to fix Release build error Agent-Logs-Url: https://github.com/porrey/Virtual-ZPL-Printer/sessions/a87b588b-5c0a-477f-a6a7-755914bf35fe Co-authored-by: porrey <12475115+porrey@users.noreply.github.com>
…ries from vdproj Agent-Logs-Url: https://github.com/porrey/Virtual-ZPL-Printer/sessions/f3e1fcab-f2bc-45e7-8e50-e7aded286cb3 Co-authored-by: porrey <12475115+porrey@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Virtual ZPL Printer solution/projects to resolve build configuration issues by standardizing the solution to x64-only builds and aligning project platform settings accordingly.
Changes:
- Removed
Any CPUsolution/platform configurations and normalized solution metadata (VisualStudioVersion) to a standard format. - Updated all project files to declare only the
x64platform. - Updated test coverage tooling (
coverlet.collector) and adjusted the setup project outputs to avoid problematic localized resource output entries.
Reviewed changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Src/Virtual Printer Solution/ZPL Printer Solution.sln | Normalizes VS version string and removes Any CPU solution/project configuration mappings. |
| Src/Virtual Printer Solution/VirtualPrinter/Virtual ZPL Printer.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.Tests/VirtualPrinter.Tests.csproj | Restricts platforms to x64 and updates coverlet.collector version. |
| Src/Virtual Printer Solution/VirtualPrinter.TemplateManager/VirtualPrinter.TemplateManager.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.TcpClient/VirtualPrinter.TestClient.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.Repository.LabelParameters/VirtualPrinter.Repository.LabelParameters.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.Repository.HostAddresses/VirtualPrinter.Repository.HostAddresses.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.PublishSubscribe/VirtualPrinter.PublishSubscribe.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.HostedService.TcpSystem/VirtualPrinter.HostedService.TcpSystem.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.HostedService.PrintSystem/VirtualPrinter.HostedService.PrintSystem.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.Handler.Zpl/VirtualPrinter.Handler.Zpl.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.Handler.Nop/VirtualPrinter.Handler.Nop.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.Handler.HostStatus/VirtualPrinter.Handler.HostStatus.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.Handler.Abstractions/VirtualPrinter.Handler.Abstractions.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.FontService/VirtualPrinter.FontService.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.Db.Ef/VirtualPrinter.Db.Ef.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.Db.Abstractions/VirtualPrinter.Db.Abstractions.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter.ApplicationSettings/VirtualPrinter.ApplicationSettings.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/VirtualPrinter-Setup/VirtualPrinter-Setup.vdproj | Removes a localized resource output entry that could interfere with setup project builds. |
| Src/Virtual Printer Solution/Labelary.Service/Labelary.Service.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/Labelary.Abstractions/Labelary.Abstractions.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/Labelary Example/Labelary Example.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/ImageCache.Repository/ImageCache.Repository.csproj | Restricts declared project platforms to x64. |
| Src/Virtual Printer Solution/ImageCache.Abstractions/ImageCache.Abstractions.csproj | Restricts declared project platforms to x64. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
16
to
20
| <SignAssembly>False</SignAssembly> | ||
| <GenerateSatelliteAssembliesForCore>true</GenerateSatelliteAssembliesForCore> | ||
| <UICulture>en-US</UICulture> | ||
| <Platforms>AnyCPU;x64</Platforms> | ||
| <Platforms>x64</Platforms> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
The platform restriction is being repeated across many project files. To reduce duplication and the risk of future projects drifting (e.g., someone adds a new project and forgets to set Platforms), consider moving the <Platforms>x64</Platforms> setting to Directory.Build.props (or a shared Directory.Build.targets) and removing it from individual .csproj files unless a project truly needs a different platform list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.