fix: selection translate broken on macOS Tahoe 26.x - #1265
Open
aayjaa wants to merge 1 commit into
Open
Conversation
- Add macos_compat.rs: Tahoe-compatible text selection with retry logic - AX API retries up to 3 times with 50ms delays (handles timing issues) - Improved clipboard fallback with 150ms delay - Comprehensive logging for debugging - Update window.rs: use macos_compat on macOS, keep selection crate for others - Update main.rs: enhanced accessibility permission check with warning - Update Cargo.toml: bump macos-accessibility-client 0.0.1 -> 0.0.2 Fixes pot-app#1128, pot-app#1138
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Selection translate (划词翻译) fails on macOS Tahoe 26.x:
Fix
New
macos_compat.rs: Tahoe-compatible text selectionwindow.rs: Usemacos_compaton macOS, keepselectioncrate for other platformsmain.rs: Enhanced accessibility check with warning when not trustedCargo.toml: Bumpmacos-accessibility-client0.0.1 → 0.0.2Testing
Requires macOS Tahoe 26.x machine:
cd src-tauri && cargo build --release[macos_compat]prefix messages