Deprecate and add a remplacement function to get country name - #4053
Deprecate and add a remplacement function to get country name#4053lejeana wants to merge 3 commits into
Conversation
Deprecate the function getName() as a function called name() already exist which lead to confusion. Added a new function with the same behaviour and whose name is more explicit : getFullName(). Signed-off-by: Alexandre Le Jean <alexandre.le-jean@artelys.com>
github-project-automation
Bot
moved this from Waiting for review
to Approved
in Release 09/2026
colineplqt
left a comment
colineplqt
left a comment
There was a problem hiding this comment.
Thank you for this pull request. Could you modify the code so that the calls to getName() are replaced by getFullName?
…unction replace call to deprecated function getName() by its replacement function getFullName() Signed-off-by: Alexandre Le Jean <alexandre.le-jean@artelys.com>
|
calls to getName() are now replaced by the new function getFullName() also, fixture deprecated allows to precise if the function will be removed in futher version, should we set it to true? |
Signed-off-by: Alexandre Le Jean <alexandre.le-jean@artelys.com>
|
I think you can add the version since when the method is deprecated (7.4.0). I would say that it is a function that could be removed after some time, but both is fine. |
3 participants
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#3571
What kind of change does this PR introduce?
Deprecate the function getName() as a function called name() already exist which lead to confusion. Added a new function with the same behaviour and whose name is more explicit : getFullName().
What is the current behavior?
#3571
What is the new behavior (if this is a feature change)?
Deprecated a function and add a remplacement function with the same behaviour.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Change call to function
Country::getName()toCountry::getFullName()asCountry::getName()is now deprecated and will later be removed.Both functions have the same behaviour, hence no more change is required.