Skip to content

Manage a VoltageLevelFilter in GeographicalLayoutFactoryto optimize Node position computation - #821

Draft
sBouzols wants to merge 1 commit into
mainfrom
feat_GeographicalLayoutFactory_manage_voltageLevelFilter
Draft

Manage a VoltageLevelFilter in GeographicalLayoutFactoryto optimize Node position computation#821
sBouzols wants to merge 1 commit into
mainfrom
feat_GeographicalLayoutFactory_manage_voltageLevelFilter

Conversation

@sBouzols

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

feature

What is the current behavior?

Add an optional VoltageLevelFilter parameter to the GeographicalLayoutFactory constructor to avoid a large value for missingPositions which implies a long computation of missing positions on large networks when we need only some positions for a portion of the total voltageLevels.

What is the new behavior (if this is a feature change)?
Now, position computation is implemented considering the given VoltageLevelFilter

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

What changes might users need to make in their application due to this PR? (migration steps)

No migration needed.
Add a VoltageLeveFilter to the constructor to optimize position computation for large networks

… parameter to the GeographicalLayoutFactory constructor to avoid a large value for `missingPositions` on large networks when we need only some positions for a portion of the total voltageLevels

Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
@sBouzols
sBouzols marked this pull request as draft June 12, 2026 12:37
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants