Fix non-idempotent voltage level layout run

[samirromdhani]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?

Fixes #289
What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

• Yes
• No

If yes, please check if the following requirements are fulfilled

• The Breaking Change or Deprecated label has been added
• The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Root cause

• cellDetector.detectCells(getGraph()); always creates new cells via graph.addCell()
• addPaddingToCoord() add vl padding to graph.coord on every run (coord is not reset)

[NathanDissoubray]

Have you checked that there isn't the same kind of bug for ZoneGraph and for SubstationGraph ?

[samirromdhani]

Have you checked that there isn't the same kind of bug for ZoneGraph and for SubstationGraph ?

Yes, both use VoltageLevelLayoutFactory, so the fix applies there too.
Added equivalent tests for substation and zone graph.

[So-Fras]

Thanks for the work! I left first comments to discuss.

[So-Fras]

I don't see the link with the 2nd root cause mentioned in the PR description.

[samirromdhani]

Here, I just preferred using the getter, the two root causes are added in the same method clearCells

    public void clearCells() {
        cells.clear();        // first root cause
        cellCounter = 0;      // first root cause
        setCoord(0, 0);       // second root cause
    }

[samirromdhani]

The root causes:

powsybl-diagram/single-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/layout/ImplicitCellDetector.java

Lines 67 to 68 in 952186b

	for (Set<Node> nodes : internCellsNodes) {
	graph.addCell(new InternCell(graph.getNextCellNumber(), nodes));

powsybl-diagram/single-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/model/graphs/VoltageLevelGraph.java

Lines 496 to 497 in 952186b

	public void addCell(Cell c) {
	cells.add(c);

cells was not initialized when the layout was run twice => fixed by cells.clear()
graph.getNextCellNumber() was not initialized when the layout was run twice => fixed by cellCounter = 0

powsybl-diagram/single-line-diagram/single-line-diagram-core/src/main/java/com/powsybl/sld/model/graphs/VoltageLevelGraph.java

Line 601 in 952186b

setCoord(coord.getX() + dPadding.left() + vlPadding.left(),

Coord was not initialized when the layout was run twice => fixed by setCoord(0, 0)

[So-Fras]

Suggested change

	Networks.createLoad(vl, "l", "l", "l", 0, ConnectablePosition.Direction.TOP, 2, 10, 10);
	Networks.createLoad(vl, "l", 0, ConnectablePosition.Direction.TOP, 2, 10, 10);

[So-Fras]

Suggested change

	Networks.createBusBarSection(vl, "bbs", "bbs", 0, 1, 1);
	Networks.createBusBarSection(vl, "bbs", 0, 1, 1);

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud