fix: print PHP 8.5 clone with (clone($obj, [...])) (#2531)

php-parser 3.7 parses the PHP 8.5 clone-with form into
`clone.properties`, but the printer only printed `what`, so

    $copy = clone($obj, ['name' => $name]);

was silently rewritten as `$copy = clone $obj;`, dropping the
property overrides (exit code 0).

Print it laid out like a two-argument call, mirroring
printArgumentsList: on one line while it fits, otherwise hugging a
trailing array (`clone($obj, [` ... `])`), otherwise one argument per
line. The broken-out form has no trailing comma because php-parser
does not accept one after the properties expression yet.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

Author: mreiden

src/printer.mjs

@@ -2161,11 +2161,64 @@ function printNode(path, options, print) {
 
       return parts;
     }
-    case "clone":
+    case "clone": {
+      if (!node.properties) {
+        return [
+          "clone ",
+          node.what.comments ? indent(print("what")) : print("what"),
+        ];
+      }
+
+      // PHP 8.5 clone with: `clone($obj, ['prop' => $value])`, laid out like
+      // a call with two arguments (see printArgumentsList). No trailing comma:
+      // php-parser does not accept one after the properties expression.
+      const printedWhat = print("what");
+      const printedProperties = print("properties");
+      const printedArguments = [printedWhat, ",", line, printedProperties];
+      const allArgsBrokenOut = () =>
+        group(["clone(", indent([line, ...printedArguments]), line, ")"], {
+          shouldBreak: true,
+        });
+
+      if (!shouldGroupLastArg([node.what, node.properties])) {
+        return group(
+          ["clone(", indent([softline, ...printedArguments]), softline, ")"],
+          {
+            shouldBreak: willBreak(printedWhat) || willBreak(printedProperties),
+          }
+        );
+      }
+
+      const somePrintedArgumentsWillBreak =
+        willBreak(printedWhat) || willBreak(printedProperties);
+      const simpleConcat = [
+        "clone(",
+        printedWhat,
+        ", ",
+        printedProperties,
+        ")",
+      ];
+
       return [
-        "clone ",
-        node.what.comments ? indent(print("what")) : print("what"),
+        somePrintedArgumentsWillBreak ? breakParent : "",
+        conditionalGroup(
+          [
+            somePrintedArgumentsWillBreak
+              ? ifBreak(allArgsBrokenOut(), simpleConcat)
+              : simpleConcat,
+            [
+              "clone(",
+              printedWhat,
+              ", ",
+              group(printedProperties, { shouldBreak: true }),
+              ")",
+            ],
+            allArgsBrokenOut(),
+          ],
+          { shouldBreak: willBreak(printedWhat) }
+        ),
       ];
+    }
     case "propertylookup":
     case "nullsafepropertylookup":
     case "staticlookup":

tests/clone-with/__snapshots__/jsfmt.spec.mjs.snap

@@ -0,0 +1,49 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`clone-with.php 1`] = `
+====================================options=====================================
+parsers: ["php"]
+phpVersion: "8.5"
+printWidth: 80
+                                                                                | printWidth
+=====================================input======================================
+<?php
+
+$copy = clone($obj);
+$copy = clone($obj, ['name' => $name]);
+$copy = clone($this->template, ['id' => null, 'createdAt' => new DateTimeImmutable()]);
+$copy = clone($obj, $overrides);
+$copy = clone($obj, array_merge($defaults, ['name' => $name, 'email' => $email, 'createdAt' => $now]));
+$copy = clone($this->veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongPropertyName, ['id' => null, 'createdAt' => $now, 'updatedAt' => $now]);
+$copy = clone($obj, [
+    'name' => $name,
+]);
+
+=====================================output=====================================
+<?php
+
+$copy = clone $obj;
+$copy = clone($obj, ["name" => $name]);
+$copy = clone($this->template, [
+    "id" => null,
+    "createdAt" => new DateTimeImmutable(),
+]);
+$copy = clone($obj, $overrides);
+$copy = clone(
+    $obj,
+    array_merge($defaults, [
+        "name" => $name,
+        "email" => $email,
+        "createdAt" => $now,
+    ])
+);
+$copy = clone(
+    $this->veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongPropertyName,
+    ["id" => null, "createdAt" => $now, "updatedAt" => $now]
+);
+$copy = clone($obj, [
+    "name" => $name,
+]);
+
+================================================================================
+`;

tests/clone-with/clone-with.php

@@ -0,0 +1,11 @@
+<?php
+
+$copy = clone($obj);
+$copy = clone($obj, ['name' => $name]);
+$copy = clone($this->template, ['id' => null, 'createdAt' => new DateTimeImmutable()]);
+$copy = clone($obj, $overrides);
+$copy = clone($obj, array_merge($defaults, ['name' => $name, 'email' => $email, 'createdAt' => $now]));
+$copy = clone($this->veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongPropertyName, ['id' => null, 'createdAt' => $now, 'updatedAt' => $now]);
+$copy = clone($obj, [
+    'name' => $name,
+]);

tests/clone-with/jsfmt.spec.mjs

@@ -0,0 +1 @@
+run_spec(import.meta, ["php"], { phpVersion: "8.5" });