Repository navigation
Conversation
PHP does not allow calling, indexing or accessing a member of a bare `match` expression, so `(match (...) {...})()` must keep its parentheses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP doesn't allow calling, indexing or accessing a member of a bare
matchexpression, but the parentheses around it were dropped. Laravel'sCloudBootstrapperhaswhich became
match (true) { ... }();, a syntax error. The same happens with[0],->prop,?->prop,->method(),::CONST,::$propand::method().matchnow gets the same rule asyieldinneeds-parens.mjs: parentheses when it is thewhatof a call or lookup. The newtests/match/dereference.phpcovers each case, plusmatch (...) {...} + 1, which still doesn't need any.yarn test(including the standalone build),AST_COMPARE=1 yarn test:nodeandyarn lintpass, andCloudBootstrapper.phpformats to valid PHP again.