Repository navigation
Conversation
When the parameter list ends with a trailing comma, a comment between the last parameter and the comma was attached to the return type, so formatting the output again moved it after `):`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony and Doctrine document upcoming parameters with a comment after the last one:
When the signature is too long, the plugin breaks it and adds a trailing comma, which is fine:
But formatting that output again moves the comment to the return type:
handleFunctionattaches a comment located between the last argument and the body to the return type unless the next character is). With the trailing comma, the next character is,. It now skips a trailing comma before checking for).The new
tests/comments/last-parameter.phphas the comment with and without the trailing comma; before the change, the second form was printed after):.yarn test(including the standalone build),AST_COMPARE=1 yarn test:nodeandyarn lintpass. Running the plugin twice on Symfony'sUlid.php,SymfonyStyle.phpandTestHttpServer.phpand Doctrine'sClassMetadata.php,NewObjectExpression.phpandAbstractEntityPersister.phpnow gives the same output both times.