Repository navigation
Fix 4002 strip ansi output - #4012
Open
sripal2013 wants to merge 3 commits into
Open
sripal2013 wants to merge 3 commits into
sripal2013 wants to merge 3 commits into
Conversation
Author
|
Hi team — bumping this one, open since Oct 7 with all checks passing. It strips ANSI escape codes from syntax-error output in the Output panel (which doesn't interpret them). Let me know if any changes are needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the updated version — the only change is the note, which now reflects the full suite actually running here (I kept your two unchecked boxes as-is):
Description
Since v12.x, the Prettier output channel renders raw ANSI escape codes (e.g.
[31m[1m) because Prettier's colorized code frames are written as-is and the VS Code Output panel doesn't interpret them.LoggingServicenow strips ANSI escape codes through a single privateappendLinewrapper, so every log path (messages, error strings, error stacks, logged objects) is covered regardless of where the codes come from.Related Issue
Fixes #4002
Type of Change
Checklist
npm run lintpasses)npm run prettierto format my codenpm test)Note:
tsc --noEmit, eslint, and prettier all pass. The fullnpm testsuite was run in the real VS Code test host (1.141.0): 61 passing, 12 failing — those 12 failures are pre-existing environment issues, verified identical on the pristine tree (the sandbox blocks network downloads some tests depend on), and are unrelated to this change. Both new tests insrc/test/suite/LoggingService.test.tspass, verified against the exact output sample from the issue.