Repository navigation
Honor shuffling with multiple SGD minibatches - #474
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
AHMETHAKANBEZIR1 wants to merge 1 commit into
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_sgd(..., shuffle=True)silently disables shuffling when the batch size exceeds the number of batches, even if there are multiple batches. For example, 10 samples with batch_size=5 always use the original order. This also affectsSSM.fit_sgd, which delegates its updates to this utility.Compare the batch size with the number of samples instead. Keep the existing no-shuffle shortcut for a full-data batch, and preserve minibatch/epoch/loss definitions.
Validation on Windows / Python 3.12.14 / JAX 0.12.0, CPU:
pytest --cov=./: 245 passed (736 warnings), 81% coverage.git diff --checkpass.Prepared autonomously with OpenAI Codex, including code and tests; no independent human review is claimed.