[avinxshKD]

Fixes #3937

sinon, sinon-mongoose, jest-express, and mongodb-memory-server were sitting in dependencies instead of devDependencies, meaning they get pulled in on every production install for no reason. Moved them where they belong.

Changes:
Moved 4 test-only packages from dependencies to devDependencies in package.json.

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• has no typecheck errors (npm run typecheck)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #3937
• meets the standards outlined in the accessibility guidelines

[avinxshKD]

Hey @raclim pls take a look, just moved the four packages to devDependencies, alphabetical order preserved.

Also what do you think of this #3922

[yugalkaushik]

LGTM

[yugalkaushik]

I just went through the file and found that jsdom, csslint, htmlhint, jshint can also be moved to devDependencies (yeah, I rechecked they are used, my bad)

[avinxshKD]

Hey @yugalkaushik thanks for reviewing, also csslint, htmlhint, and jshint are actively used at runtime to lint user code in the editor, not test tooling. jsdom is the same. Moving those would break prod.
Happy to investigate further if needed though

[avinxshKD]

Hey @raclim pls take a look, when get time thanks

[avinxshKD]

@raclim can you look at this?

[avinxshKD]

ptal @doradocodes

[clairep94]

Hi @avinxshKD thanks for this!
The changes look good but could you re-generate a lock file and include that with the PR?

Make sure to use the npm version for this repo by running nvm use first

[clairep94]

As mentioned we'll need to regenerate the lock file

As an aside, maintainers should add a pre-commit hook or a CI check to flag when lock files are expected to be changed but have not been

[clairep94]

As mentioned we'll need to regenerate the lock file

As an aside, maintainers should add a pre-commit hook or a CI check to flag when lock files are expected to be changed but have not been

cc: @doradocodes, see comment re: lack of check for lockfile changes