Skip to content

Fix link accessibility - #4159

Merged
doradocodes merged 7 commits into
processing:developfrom
VikasKSingh05:fix-link-accessibility
Oct 28, 2026
Merged

doradocodes merged 7 commits into
processing:developfrom
VikasKSingh05:fix-link-accessibility

Conversation

@VikasKSingh05

Copy link
Copy Markdown
Contributor

Resolves #4126

Changes

Accessibility color updates

  • Renamed p5-contrast-pink to p5-contrast-light-pink (#FFA9D9)
  • Added a new p5-contrast-dark-pink color (#B20046)
  • Updated existing references to use p5-contrast-light-pink

Theme-specific link colors

  • Light theme links now use p5-contrast-dark-pink
  • Dark theme links now use p5-contrast-light-pink
  • Contrast theme links continue to use p5-contrast-light-pink

Link styling updates

  • Updated shared link styling to use the theme-specific link-text-color variable instead of hardcoded color values
  • Updated About page contact/footer links to use the accessibility-compliant theme link color
  • Preserved existing hover and underline behavior

Why

This change improves link accessibility by ensuring link colors meet WCAG contrast requirements for small text while maintaining consistent behavior across themes.

QA Steps

  1. Start the web editor locally.
  2. Switch to Light Mode.
    • Verify links appear in dark pink (#B20046).
  3. Switch to Dark Mode.
    • Verify links appear in light pink (#FFA9D9).
  4. Switch to Contrast Mode.
    • Verify links appear in light pink (#FFA9D9).
  5. Open the Preferences dialog and verify links use the correct theme color.
  6. Open the About page and verify contact/footer links use the correct theme color.
  7. Confirm links remain underlined and visually distinguishable from surrounding text in all themes.

Screenshots

Light Mode

Screenshot 2026-06-06 154218

Dark Mode

Screenshot 2026-06-06 154305 image

@runningonsideprojects

Copy link
Copy Markdown
Collaborator

✅ Light mode link color #b20046

image

✅ Dark mode link color #ffa9d9

image

✅ Contrast mode link color #ffa9d9

image

@runningonsideprojects

Copy link
Copy Markdown
Collaborator

hey @VikasKSingh05 incredible sorry for this belated review. Please take a look at my comments! Eager to get your PR merged soon. Thanks for the great work on this

@runningonsideprojects

Copy link
Copy Markdown
Collaborator

@VikasKSingh05, gently checking in!

per p5js policy, we may close this PR if we do not receive a timely follow up on your status!

@VikasKSingh05

Copy link
Copy Markdown
Contributor Author

Hi @runningonsideprojects, thanks for checking in! I'm still interested in getting this PR merged. I’ve completed the changes requested for #4159 and the PR currently reflects the three theme-specific link colors you confirmed. I don’t see any unresolved review comments on the PR at the moment. Please let me know if there’s anything else you’d like me to address, and I’ll take care of it.

@runningonsideprojects

Copy link
Copy Markdown
Collaborator

Hi @runningonsideprojects, thanks for checking in! I'm still interested in getting this PR merged. I’ve completed the changes requested for #4159 and the PR currently reflects the three theme-specific link colors you confirmed. I don’t see any unresolved review comments on the PR at the moment. Please let me know if there’s anything else you’d like me to address, and I’ll take care of it.

Thanks! Are you unable to see these comments in this PR?

image

@VikasKSingh05

Copy link
Copy Markdown
Contributor Author

@runningonsideprojects, I've addressed all three review comments: moved link-text-color into alphabetical order for all three themes, removed the extra space after the comma, and updated the dark theme error-color to $p5-contrast-light-pink. I've committed the changes to the PR. Please take another look when you get a chance!

@runningonsideprojects runningonsideprojects left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you for your amazing work on this :) @VikasKSingh05

Comment thread client/styles/abstracts/_variables.scss Resolved
Comment thread client/styles/abstracts/_variables.scss Resolved
Comment thread client/styles/abstracts/_variables.scss Resolved
@runningonsideprojects

Copy link
Copy Markdown
Collaborator

oh one more thing @VikasKSingh05 can u your branch is rebased with the master branch properly?

image

@VikasKSingh05
VikasKSingh05 force-pushed the fix-link-accessibility branch from 7f708e3 to 056dfba Compare October 7, 2026 15:52
@VikasKSingh05

Copy link
Copy Markdown
Contributor Author

I've rebased the PR branch onto the latest develop and pushed the updated changes. Please take another look when you get a chance @runningonsideprojects !

@doradocodes
doradocodes enabled auto-merge October 28, 2026 17:53
@doradocodes
doradocodes merged commit f94c407 into processing:develop Oct 28, 2026
2 checks passed

This branch was successfully deployed

1 active deployment
e2e-tests — 3d23b8ea Deployed Oct 28, 2026 by doradocodes via test-e2e #407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing link colors to be higher contrast

3 participants