Repository navigation
Fix link accessibility - #4159
Conversation
|
hey @VikasKSingh05 incredible sorry for this belated review. Please take a look at my comments! Eager to get your PR merged soon. Thanks for the great work on this |
|
@VikasKSingh05, gently checking in! per p5js policy, we may close this PR if we do not receive a timely follow up on your status! |
|
Hi @runningonsideprojects, thanks for checking in! I'm still interested in getting this PR merged. I’ve completed the changes requested for #4159 and the PR currently reflects the three theme-specific link colors you confirmed. I don’t see any unresolved review comments on the PR at the moment. Please let me know if there’s anything else you’d like me to address, and I’ll take care of it. |
Thanks! Are you unable to see these comments in this PR?
|
|
@runningonsideprojects, I've addressed all three review comments: moved link-text-color into alphabetical order for all three themes, removed the extra space after the comma, and updated the dark theme error-color to $p5-contrast-light-pink. I've committed the changes to the PR. Please take another look when you get a chance! |
runningonsideprojects
left a comment
There was a problem hiding this comment.
looks great! thank you for your amazing work on this :) @VikasKSingh05
|
oh one more thing @VikasKSingh05 can u your branch is rebased with the master branch properly?
|
Removed and re-added link-text-color for light and dark themes.
7f708e3 to
056dfba
Compare
|
I've rebased the PR branch onto the latest develop and pushed the updated changes. Please take another look when you get a chance @runningonsideprojects ! |





Resolves #4126
Changes
Accessibility color updates
p5-contrast-pinktop5-contrast-light-pink(#FFA9D9)p5-contrast-dark-pinkcolor (#B20046)p5-contrast-light-pinkTheme-specific link colors
p5-contrast-dark-pinkp5-contrast-light-pinkp5-contrast-light-pinkLink styling updates
link-text-colorvariable instead of hardcoded color valuesWhy
This change improves link accessibility by ensuring link colors meet WCAG contrast requirements for small text while maintaining consistent behavior across themes.
QA Steps
#B20046).#FFA9D9).#FFA9D9).Screenshots
Light Mode
Dark Mode