Repository navigation
Keep original line numbers when loop protection is on - #4358
Merged
doradocodes merged 4 commits intoOct 28, 2026
Merged
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
davepagurek
self-requested a review
October 15, 2026 15:37
davepagurek
approved these changes
Oct 21, 2026
davepagurek
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me! I'm going to get a web editor maintainer to take a look too to make sure there's nothing else I'm missing.
doradocodes
enabled auto-merge
October 28, 2026 17:35
doradocodes
requested a deployment
to
e2e-tests
October 28, 2026 17:36 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #4356
Loop protection currently regenerates the whole sketch after modifying the AST. That changes the original source layout by removing comments and blank lines and reformatting the code, so runtime errors can end up pointing to the wrong line in the editor.
Changes:
AI tools were used as an assistive tool during investigation and implementation. I reviewed the final diff and verified the behaviour and tests locally.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123