Repository navigation
Cancel superseded CI test runs (unit test & e2e test) - #4383
Merged
Merged
Conversation
clairep94
marked this pull request as ready for review
October 28, 2026 14:04
There was a problem hiding this comment.
🟡 Changes recommended
Concurrency groups can still cancel pending Test/E2E runs and let failed or cancelled Test completions displace successful pending deployments, causing intended deployments to be lost.
2 open issues
What changed in this PR
This PR adjusts CI concurrency to cancel superseded pull-request tests and prepares deployment workflows for successful-test gating.
Changes:
- Adds concurrency controls to unit-test and E2E workflows.
- Serializes deployments per environment and requires successful Test completion for production deployment.
- Upgrades checkout and Node setup actions in the unit-test workflow to v4.
| File | Description |
|---|---|
.github/workflows/test.yml |
Adds test concurrency controls and upgrades setup actions. |
.github/workflows/e2e.yml |
Adds concurrency controls for superseded PR runs. |
.github/workflows/deploy.yml |
Adds production deployment concurrency and a successful-test guard. |
.github/workflows/deploy-staging.yml |
Adds staging deployment concurrency. |
Review effort: Balanced
…ts based on workflow run conclusion for skipping tests that were not successful
…ts based on workflow run conclusion for skipping tests that were not successful
clairep94
force-pushed
the
clairep94/test_concurrency
branch
from
October 28, 2026 14:58
8e36e71 to
c71980d
Compare
doradocodes
approved these changes
Oct 28, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issue:
Fixes #4284 - p1
Prepares CI tests to allow for e2e tests to automatically run after successful unit tests. see next PR
test.ymlande2e.ymlto cancel superseded PR runs, if triggers is an open or updates to a PRtest.ymltest.ymlDemo:
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123