Skip to content

Cancel superseded CI test runs (unit test & e2e test) - #4383

Merged
clairep94 merged 17 commits into
developfrom
clairep94/test_concurrency
Oct 30, 2026
Merged

clairep94 merged 17 commits into
developfrom
clairep94/test_concurrency

Conversation

@clairep94

@clairep94 clairep94 commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Issue:

Fixes #4284 - p1
Prepares CI tests to allow for e2e tests to automatically run after successful unit tests. see next PR

  • adds concurrency rules for test.yml and e2e.yml to cancel superseded PR runs, if triggers is an open or updates to a PR
  • update deploy.yml to match deploy-staging -- only trigger when "Test" conclusion is 'success' instead of any 'completed' result ('cancelled', 'failed', etc)
  • bump checkout and setup-node to v4 in test.yml
  • cache setup node in test.yml

Demo:

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@clairep94
clairep94 added this pull request to stack #4385 October 28, 2026 13:59
@clairep94 clairep94 changed the title update e2e and unit test to cancel superseded PR runs Cancel superseded CI test runs (unit test & e2e test) Oct 28, 2026
@clairep94
clairep94 marked this pull request as ready for review October 28, 2026 14:04
@clairep94
clairep94 requested a balanced review from Copilot October 28, 2026 14:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Concurrency groups can still cancel pending Test/E2E runs and let failed or cancelled Test completions displace successful pending deployments, causing intended deployments to be lost.

2 open issues
What changed in this PR

This PR adjusts CI concurrency to cancel superseded pull-request tests and prepares deployment workflows for successful-test gating.

Changes:

  • Adds concurrency controls to unit-test and E2E workflows.
  • Serializes deployments per environment and requires successful Test completion for production deployment.
  • Upgrades checkout and Node setup actions in the unit-test workflow to v4.
File Description
.github/​workflows/​test.yml Adds test concurrency controls and upgrades setup actions.
.github/​workflows/​e2e.yml Adds concurrency controls for superseded PR runs.
.github/​workflows/​deploy.yml Adds production deployment concurrency and a successful-test guard.
.github/​workflows/​deploy-staging.yml Adds staging deployment concurrency.

Review effort: Balanced

Comment thread .github/workflows/deploy.yml Resolved
Comment thread .github/workflows/test.yml Resolved
…ts based on workflow run conclusion for skipping tests that were not successful
@clairep94
clairep94 force-pushed the clairep94/test_concurrency branch from 8e36e71 to c71980d Compare October 28, 2026 14:58
@clairep94
clairep94 merged commit 5bb415b into develop Oct 30, 2026
2 checks passed

This branch was successfully deployed

1 active deployment
e2e-tests — ba3cc3b8 Deployed Oct 30, 2026 by clairep94 via test-e2e #425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make e2e tests mandatory for PR merging

3 participants