Repository navigation
Fix loadModel normalize overload validation - #9286
Conversation
aashu2006
left a comment
There was a problem hiding this comment.
thanks @xsupremeyx, LGTM !
I checked it in a sketch and loadModel(path, true) doesn't give the false error anymore, and the generated parameterData.json entry matches what npm run docs gives. loadModel(path, callback) still gets a similar false error btw, but that is separate from this issue so that could be a follow up
cc @davepagurek
Thanks for testing it and confirming the fix works! I'll keep this PR focused on the normalize overload. Happy to look into the callback issue separately if needed! |
davepagurek
left a comment
There was a problem hiding this comment.
Looks good, thanks! And thanks @aashu2006 for reviewing! Feel free to file a follow up issue for the other overloads you noticed working but reporting false positive FES messages.
|
@all-contributors please add @xsupremeyx for code |
|
I've put up a pull request to add @xsupremeyx! 🎉 |
Resolves #9176
Changes
loadModel(path, normalize, successCallback, failureCallback)overload insrc/webgl/loading.js.docs/parameterData.jsonto recognize the Booleannormalizeargument and prevent a false-positive Friendly Errors warning.test/unit/core/param_errors.jsto verify thatloadModel(path, true)passes parameter validation.Screenshots of the change
Not applicable. This change affects parameter validation, not canvas rendering.
PR Checklist
npm run lintpasses (targeted lint passed; full-project lint reported 44 warnings, including warnings in files unrelated to this change).