Repository navigation
Fix/correctness and swagger - #5
Merged
Merged
Conversation
- Add @nestjs/swagger and swagger-ui-express dependencies - Add Swagger setup in main.ts with API title and bearer auth - Add @apitags and @apioperation decorators to all controllers - Split lint script: 'lint' (check only) and 'lint:fix' (with --fix) - CI uses 'npm run lint' to prevent silent file modifications
- Type Express Request objects in decorators (UserId, CurrentUserId) - Add explicit types to test helper functions (registerAndLogin) - Add type guards for error handling (P2034, P2002) in services - Update error catch types from 'any' to 'unknown' with proper checks - Add file-level eslint-disable for supertest response bodies (necessary for test files) - Add type casting for Prisma effects object (Record<string, unknown>) - Resolve all unsafe-assignment, unsafe-member-access, unsafe-call errors - 1 error -> 0, 100 problems -> 9 warnings (all acceptable in tests)
Owner
Author
|
CI is green. Fixed CI ordering (Prisma generate before lint), made e2e setup deterministic via explicit seeding, and verified locally + in CI. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.