Skip to content

Commit fe6ab75

Browse files
RHOAIENG-57679: add checkpointing guided notebook
1 parent f5151a6 commit fe6ab75

4 files changed

Lines changed: 576 additions & 3 deletions

File tree

.cursor/rules/03-testing-and-ci.mdc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ coverage report -m
8686
### Guided notebooks (label: test-guided-notebooks)
8787
- KinD + Kueue + KubeRay; no GPU. Notebooks: 0_basic_ray, 4_rayjob_existing_cluster, 5_submit_rayjob_cr. Run with papermill (see Demo notebooks below).
8888
- **6_autoscaling**: KinD + KubeRay only (no Kueue — autoscaling is incompatible with Kueue; see RHAIRFE-909).
89+
- **7_rayjob_checkpointing_example**: not run in CI (requires S3 Data Connection and OpenShift/RHOAI workbench; see Demo notebooks below).
8990

9091
### UI notebooks (labels: test-guided-notebooks or test-ui-notebooks)
9192
- Job: verify-3_widget_example. Playwright (chromium) in `ui-tests/`; notebook `demo-notebooks/guided-demos/3_widget_example.ipynb`.
@@ -107,7 +108,9 @@ coverage report -m
107108
| 6_autoscaling.ipynb | Guided | KinD: KubeRay only (no Kueue), namespace='default', rayproject image, verify_tls=False, dashboard_check=False, shorter load job, 1800s timeout |
108109
| 3_widget_example.ipynb | UI | Playwright in ui-tests/; namespace='default', view_clusters('default'), remove auth cells |
109110

110-
**Skipped in CI** (require mTLS/OpenShift): local_interactive.ipynb, ray_job_client.ipynb.
111+
**Skipped in CI**:
112+
- `local_interactive.ipynb`, `ray_job_client.ipynb` — require mTLS/OpenShift (not available in KinD).
113+
- `7_rayjob_checkpointing_example.ipynb` — requires S3 Data Connection and OpenShift/RHOAI workbench credentials.
111114

112115
### KinD-specific adaptations (CI applies these)
113116
- **Auth**: Remove cells that do auth/login (e.g. "Create authentication object for user permissions", `auth.logout()`, `oc login`) — KinD doesn't support token auth the same way.

AGENTS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,8 @@ Real examples for the most common change types. Follow these patterns, not descr
228228

229229
### Updating example notebooks
230230

231-
- Guided demos: `demo-notebooks/guided-demos/` (7 notebooks: `0_basic_ray` through
232-
`6_autoscaling`)
231+
- Guided demos: `demo-notebooks/guided-demos/` (8 notebooks: `0_basic_ray` through
232+
`7_rayjob_checkpointing_example`)
233233
- CI workflow: `.github/workflows/guided_notebook_tests.yaml` — runs on KinD via
234234
papermill. See `.cursor/rules/03-testing-and-ci.mdc` for KinD adaptations
235235
(namespace, auth removal, dashboard_check=False).

0 commit comments

Comments
 (0)