Skip to content
This repository was archived by the owner on Aug 29, 2022. It is now read-only.
This repository was archived by the owner on Aug 29, 2022. It is now read-only.

groups look up should be done at token verification time #11

Description

@rajatjindal

So I was talking to a gentleman at Kubecon, and they are using an internal fork of kubernetes-ldap and he brought up a very good point.

today we get the list of groups for users at token generation time, and then add that to token and its valid until that token is valid.

Now if the group membership has changed, while the token is still valid, we dont see that change. This can be a security issue as well.

We should probably do group look up at token validation time.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions